path: root/virt
diff options
authorPavel Skripkin <>2021-07-01 22:55:00 +0300
committerPaolo Bonzini <>2021-07-15 10:19:40 -0400
commit004d62eb4e57db3c391ed0df007cc11c93b6fbeb (patch)
tree9c2d08dc7ed7666f7bc01b51623b03b6801d7d1d /virt
parent7234c362ccb3c2228f06f19f93b132de9cfa7ae4 (diff)
kvm: debugfs: fix memory leak in kvm_create_vm_debugfs
In commit bc9e9e672df9 ("KVM: debugfs: Reuse binary stats descriptors") loop for filling debugfs_stat_data was copy-pasted 2 times, but in the second loop pointers are saved over pointers allocated in the first loop. All this causes is a memory leak, fix it. Fixes: bc9e9e672df9 ("KVM: debugfs: Reuse binary stats descriptors") Signed-off-by: Pavel Skripkin <> Reviewed-by: Jing Zhang <> Message-Id: <> Reviewed-by: Jing Zhang <> Signed-off-by: Paolo Bonzini <>
Diffstat (limited to 'virt')
1 files changed, 1 insertions, 1 deletions
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index f7445c3bcd90..6980dabe9df5 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -935,7 +935,7 @@ static int kvm_create_vm_debugfs(struct kvm *kvm, int fd)
stat_data->kvm = kvm;
stat_data->desc = pdesc;
stat_data->kind = KVM_STAT_VCPU;
- kvm->debugfs_stat_data[i] = stat_data;
+ kvm->debugfs_stat_data[i + kvm_vm_stats_header.num_desc] = stat_data;
debugfs_create_file(pdesc->name, kvm_stats_debugfs_mode(pdesc),
kvm->debugfs_dentry, stat_data,