path: root/security/selinux
diff options
authorAmir Goldstein <>2020-12-19 12:05:27 +0200
committerPaul Moore <>2021-01-04 20:41:09 -0500
commita9ffe682c58aaff643764547f5420e978b6e0830 (patch)
tree9726400d6558859dd38e83caec80cceba6a4885a /security/selinux
parent95ca90726ea6c9444c752ea370e35ec7b6776434 (diff)
selinux: fix inconsistency between inode_getxattr and inode_listsecurity
When inode has no listxattr op of its own (e.g. squashfs) vfs_listxattr calls the LSM inode_listsecurity hooks to list the xattrs that LSMs will intercept in inode_getxattr hooks. When selinux LSM is installed but not initialized, it will list the security.selinux xattr in inode_listsecurity, but will not intercept it in inode_getxattr. This results in -ENODATA for a getxattr call for an xattr returned by listxattr. This situation was manifested as overlayfs failure to copy up lower files from squashfs when selinux is built-in but not initialized, because ovl_copy_xattr() iterates the lower inode xattrs by vfs_listxattr() and vfs_getxattr(). Match the logic of inode_listsecurity to that of inode_getxattr and do not list the security.selinux xattr if selinux is not initialized. Reported-by: Michael Labriola <> Tested-by: Michael Labriola <> Link: Fixes: c8e222616c7e ("selinux: allow reading labels before policy is loaded") Cc: Signed-off-by: Amir Goldstein <> Reviewed-by: Ondrej Mosnacek <> Signed-off-by: Paul Moore <>
Diffstat (limited to 'security/selinux')
1 files changed, 4 insertions, 0 deletions
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 75e7568cf607..7fb7ff03eaa9 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -3414,6 +3414,10 @@ static int selinux_inode_setsecurity(struct inode *inode, const char *name,
static int selinux_inode_listsecurity(struct inode *inode, char *buffer, size_t buffer_size)
const int len = sizeof(XATTR_NAME_SELINUX);
+ if (!selinux_initialized(&selinux_state))
+ return 0;
if (buffer && len <= buffer_size)
memcpy(buffer, XATTR_NAME_SELINUX, len);
return len;