path: root/security/selinux/selinuxfs.c
diff options
authorOndrej Mosnacek <>2021-03-18 22:53:01 +0100
committerPaul Moore <>2021-03-18 23:13:04 -0400
commit519dad3bcd809dc1523bf80ab0310ddb3bf00ade (patch)
treeb01c0dacf941d602dbdce10a105e4bba14ee3949 /security/selinux/selinuxfs.c
parent365982aba1f264dba26f0908700d62bfa046918c (diff)
selinux: don't log MAC_POLICY_LOAD record on failed policy load
If sel_make_policy_nodes() fails, we should jump to 'out', not 'out1', as the latter would incorrectly log an MAC_POLICY_LOAD audit record, even though the policy hasn't actually been reloaded. The 'out1' jump label now becomes unused and can be removed. Fixes: 02a52c5c8c3b ("selinux: move policy commit after updating selinuxfs") Cc: Signed-off-by: Ondrej Mosnacek <> Signed-off-by: Paul Moore <>
Diffstat (limited to 'security/selinux/selinuxfs.c')
1 files changed, 1 insertions, 2 deletions
diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
index 01a7d50ed39b..340711e3dc9a 100644
--- a/security/selinux/selinuxfs.c
+++ b/security/selinux/selinuxfs.c
@@ -651,14 +651,13 @@ static ssize_t sel_write_load(struct file *file, const char __user *buf,
length = sel_make_policy_nodes(fsi, newpolicy);
if (length) {
selinux_policy_cancel(fsi->state, newpolicy);
- goto out1;
+ goto out;
selinux_policy_commit(fsi->state, newpolicy);
length = count;
audit_log(audit_context(), GFP_KERNEL, AUDIT_MAC_POLICY_LOAD,
"auid=%u ses=%u lsm=selinux res=1",
from_kuid(&init_user_ns, audit_get_loginuid(current)),