path: root/security/selinux/hooks.c
diff options
authorStephen Smalley <>2020-01-17 15:24:07 -0500
committerPaul Moore <>2020-01-20 07:42:37 -0500
commit98aa00345de54b8340dc2ddcd87f446d33387b5e (patch)
treeeba20964a8d90597697e375aa220b2d0d549c49d /security/selinux/hooks.c
parentdd89b9d9f37decab85e000384d229abdcd9944ae (diff)
selinux: fix regression introduced by move_mount(2) syscall
commit 2db154b3ea8e ("vfs: syscall: Add move_mount(2) to move mounts around") introduced a new move_mount(2) system call and a corresponding new LSM security_move_mount hook but did not implement this hook for any existing LSM. This creates a regression for SELinux with respect to consistent checking of mounts; the existing selinux_mount hook checks mounton permission to the mount point path. Provide a SELinux hook implementation for move_mount that applies this same check for consistency. In the future we may wish to add a new move_mount filesystem permission and check as well, but this addresses the immediate regression. Fixes: 2db154b3ea8e ("vfs: syscall: Add move_mount(2) to move mounts around") Signed-off-by: Stephen Smalley <> Reviewed-by: Ondrej Mosnacek <> Signed-off-by: Paul Moore <>
Diffstat (limited to 'security/selinux/hooks.c')
1 files changed, 10 insertions, 0 deletions
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 61085eb3cd24..d9e8b2131a65 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -2724,6 +2724,14 @@ static int selinux_mount(const char *dev_name,
return path_has_perm(cred, path, FILE__MOUNTON);
+static int selinux_move_mount(const struct path *from_path,
+ const struct path *to_path)
+ const struct cred *cred = current_cred();
+ return path_has_perm(cred, to_path, FILE__MOUNTON);
static int selinux_umount(struct vfsmount *mnt, int flags)
const struct cred *cred = current_cred();
@@ -6913,6 +6921,8 @@ static struct security_hook_list selinux_hooks[] __lsm_ro_after_init = {
LSM_HOOK_INIT(sb_set_mnt_opts, selinux_set_mnt_opts),
LSM_HOOK_INIT(sb_clone_mnt_opts, selinux_sb_clone_mnt_opts),
+ LSM_HOOK_INIT(move_mount, selinux_move_mount),
LSM_HOOK_INIT(dentry_init_security, selinux_dentry_init_security),
LSM_HOOK_INIT(dentry_create_files_as, selinux_dentry_create_files_as),