path: root/security/device_cgroup.c
diff options
authorJann Horn <>2019-03-19 02:36:59 +0100
committerTejun Heo <>2019-03-19 10:46:15 -0700
commit0fcc4c8c044e117ac126ab6df4138ea9a67fa2a9 (patch)
tree181570811ec1a929a32b9054f1f55ba7833dcecc /security/device_cgroup.c
parent9e98c678c2d6ae3a17cb2de55d17f69dddaa231b (diff)
device_cgroup: fix RCU imbalance in error case
When dev_exception_add() returns an error (due to a failed memory allocation), make sure that we move the RCU preemption count back to where it was before we were called. We dropped the RCU read lock inside the loop body, so we can't just "break". sparse complains about this, too: $ make -s C=2 security/device_cgroup.o ./include/linux/rcupdate.h:647:9: warning: context imbalance in 'propagate_exception' - unexpected unlock Fixes: d591fb56618f ("device_cgroup: simplify cgroup tree walk in propagate_exception()") Cc: Signed-off-by: Jann Horn <> Acked-by: Michal Hocko <> Signed-off-by: Tejun Heo <>
Diffstat (limited to 'security/device_cgroup.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/security/device_cgroup.c b/security/device_cgroup.c
index cd97929fac66..dc28914fa72e 100644
--- a/security/device_cgroup.c
+++ b/security/device_cgroup.c
@@ -560,7 +560,7 @@ static int propagate_exception(struct dev_cgroup *devcg_root,
devcg->behavior == DEVCG_DEFAULT_ALLOW) {
rc = dev_exception_add(devcg, ex);
if (rc)
- break;
+ return rc;
} else {
* in the other possible cases: