path: root/security/apparmor/domain.c
diff options
authorXiyu Yang <>2020-04-05 13:11:55 +0800
committerJohn Johansen <>2020-05-21 15:25:51 -0700
commita0b845ffa0d91855532b50fc040aeb2d8338dca4 (patch)
tree5ae21032e3f1024455625f8b3af80fbf672c858a /security/apparmor/domain.c
parentb85051e755b0e9d6dd8f17ef1da083851b83287d (diff)
apparmor: fix potential label refcnt leak in aa_change_profile
aa_change_profile() invokes aa_get_current_label(), which returns a reference of the current task's label. According to the comment of aa_get_current_label(), the returned reference must be put with aa_put_label(). However, when the original object pointed by "label" becomes unreachable because aa_change_profile() returns or a new object is assigned to "label", reference count increased by aa_get_current_label() is not decreased, causing a refcnt leak. Fix this by calling aa_put_label() before aa_change_profile() return and dropping unnecessary aa_get_current_label(). Fixes: 9fcf78cca198 ("apparmor: update domain transitions that are subsets of confinement at nnp") Signed-off-by: Xiyu Yang <> Signed-off-by: Xin Tan <> Signed-off-by: John Johansen <>
Diffstat (limited to 'security/apparmor/domain.c')
1 files changed, 1 insertions, 2 deletions
diff --git a/security/apparmor/domain.c b/security/apparmor/domain.c
index 6ceb74e0f789..a84ef030fbd7 100644
--- a/security/apparmor/domain.c
+++ b/security/apparmor/domain.c
@@ -1328,6 +1328,7 @@ int aa_change_profile(const char *fqname, int flags)
ctx->nnp = aa_get_label(label);
if (!fqname || !*fqname) {
+ aa_put_label(label);
AA_DEBUG("no profile name");
return -EINVAL;
@@ -1346,8 +1347,6 @@ int aa_change_profile(const char *fqname, int flags)
- label = aa_get_current_label();
if (*fqname == '&') {
stack = true;
/* don't have label_parse() do stacking */