path: root/fs/xfs/xfs_ioctl.c
diff options
authorDarrick J. Wong <>2022-02-25 16:18:30 -0800
committerDarrick J. Wong <>2022-03-09 10:32:06 -0800
commiteba0549bc7d100691c13384b774346b8aa9cf9a9 (patch)
tree1be2c9ccae0253dc7e6b184a309657abf2e48036 /fs/xfs/xfs_ioctl.c
parent1a39ae415c1be1e46f5b3f97d438c7c4adc22b63 (diff)
xfs: don't generate selinux audit messages for capability testing
There are a few places where we test the current process' capability set to decide if we're going to be more or less generous with resource acquisition for a system call. If the process doesn't have the capability, we can continue the call, albeit in a degraded mode. These are /not/ the actual security decisions, so it's not proper to use capable(), which (in certain selinux setups) causes audit messages to get logged. Switch them to has_capability_noaudit. Fixes: 7317a03df703f ("xfs: refactor inode ownership change transaction/inode/quota allocation idiom") Fixes: ea9a46e1c4925 ("xfs: only return detailed fsmap info if the caller has CAP_SYS_ADMIN") Signed-off-by: Darrick J. Wong <> Cc: Dave Chinner <> Reviewed-by: Ondrej Mosnacek <> Acked-by: Serge Hallyn <> Reviewed-by: Eric Sandeen <>
Diffstat (limited to 'fs/xfs/xfs_ioctl.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
index 2515fe8299e1..83481005317a 100644
--- a/fs/xfs/xfs_ioctl.c
+++ b/fs/xfs/xfs_ioctl.c
@@ -1189,7 +1189,7 @@ xfs_ioctl_setattr_get_trans(
goto out_error;
error = xfs_trans_alloc_ichange(ip, NULL, NULL, pdqp,
- capable(CAP_FOWNER), &tp);
+ has_capability_noaudit(current, CAP_FOWNER), &tp);
if (error)
goto out_error;