diff options
| author | Bart Van Assche <bvanassche@acm.org> | 2014-02-20 14:20:57 -0800 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2015-04-02 12:12:26 -0600 |
| commit | bce815677fba88a7b8e53b9ce222f731b61aee1a (patch) | |
| tree | 846eedaa9b8a67283fd08201ca18d89f3f65dfa3 | |
| parent | f4075067199b3eda79b67844a87a9cddedadb40c (diff) | |
remove a useless get/put_device pair in scsi_next_command
Eliminate a get_device() / put_device() pair from scsi_next_command().
Both are atomic operations hence removing these slightly improves
performance.
[hch: slight changes due to different context]
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
| -rw-r--r-- | drivers/scsi/scsi_lib.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index bc035a3ebf8b..f2996fc3f452 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -532,14 +532,9 @@ void scsi_next_command(struct scsi_cmnd *cmd) struct scsi_device *sdev = cmd->device; struct request_queue *q = sdev->request_queue; - /* need to hold a reference on the device before we let go of the cmd */ - get_device(&sdev->sdev_gendev); - scsi_put_command(cmd); - put_device(&sdev->sdev_gendev); scsi_run_queue(q); - /* ok to remove device now */ put_device(&sdev->sdev_gendev); } |