diff options
| author | Pavel Begunkov <asml.silence@gmail.com> | 2022-06-16 10:22:07 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2022-06-22 11:31:22 -0600 |
| commit | f385054166442704671e7ddbe72eded374bca3d2 (patch) | |
| tree | 9f0032eb9a1ce4a797917a944e1ec5379cfa5155 | |
| parent | 345d438ff9cdfc059e558206ebd22a7aca3a4bb6 (diff) | |
io_uring: use state completion infra for poll reqs
Use io_req_task_complete() for poll request completions, so it can
utilise state completions and save lots of unnecessary locking.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/ced94cb5a728d8e386c640d052fd3da3f5d6891a.1655371007.git.asml.silence@gmail.com
Reviewed-by: Hao Xu <howeyxu@tencent.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | io_uring/poll.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/io_uring/poll.c b/io_uring/poll.c index 5b2c6ce26a55..7f2ebb56f7db 100644 --- a/io_uring/poll.c +++ b/io_uring/poll.c @@ -234,12 +234,8 @@ static void io_poll_task_func(struct io_kiocb *req, bool *locked) io_poll_remove_entries(req); io_poll_req_delete(req, ctx); - spin_lock(&ctx->completion_lock); - req->cqe.flags = 0; - __io_req_complete_post(req); - io_commit_cqring(ctx); - spin_unlock(&ctx->completion_lock); - io_cqring_ev_posted(ctx); + io_req_set_res(req, req->cqe.res, 0); + io_req_task_complete(req, locked); } static void io_apoll_task_func(struct io_kiocb *req, bool *locked) |