diff options
authorColy Li <>2021-11-03 23:10:41 +0800
committerJens Axboe <>2021-11-08 06:23:17 -0700
commit2878feaed543c35f9dbbe6d8ce36fb67ac803eef (patch)
parent38987a872b313e72f7a64e91ec0b8084eaec0f10 (diff)
bcache: Revert "bcache: use bvec_virt"for-5.16/drivers-2021-11-09for-5.16/drivers
This reverts commit 2fd3e5efe791946be0957c8e1eed9560b541fe46. The above commit replaces page_address(bv->bv_page) by bvec_virt(bv) to avoid directly access to bv->bv_page, but in situation bv->bv_offset is not zero and page_address(bv->bv_page) is not equal to bvec_virt(bv). In such case a memory corruption may happen because memory in next page is tainted by following line in do_btree_node_write(), memcpy(bvec_virt(bv), addr, PAGE_SIZE); This patch reverts the mentioned commit to avoid the memory corruption. Fixes: 2fd3e5efe791 ("bcache: use bvec_virt") Signed-off-by: Coly Li <> Cc: Christoph Hellwig <> Cc: # 5.15 Signed-off-by: Christoph Hellwig <> Link: Signed-off-by: Jens Axboe <>
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
index 93b67b8d31c3..88c573eeb598 100644
--- a/drivers/md/bcache/btree.c
+++ b/drivers/md/bcache/btree.c
@@ -378,7 +378,7 @@ static void do_btree_node_write(struct btree *b)
struct bvec_iter_all iter_all;
bio_for_each_segment_all(bv, b->bio, iter_all) {
- memcpy(bvec_virt(bv), addr, PAGE_SIZE);
+ memcpy(page_address(bv->bv_page), addr, PAGE_SIZE);
addr += PAGE_SIZE;