diff options
authorDan Carpenter <>2011-11-24 12:59:00 +0100
committerJens Axboe <>2011-11-24 12:59:00 +0100
commit3e54a3d1b83220d748f1a27c8999634be7a83949 (patch)
parent60ec0eecfa8968d0f1188e3730979196ac28b9de (diff)
mtip32xx: uninitialized variable in mtip_quiesce_io()
We recently introduce new continue in the loop which make gcc complain. In theory if MTIP_FLAG_SVC_THD_ACTIVE_BIT is set, we could hit continue over and over until eventually we time out of the loop. In that case "active" should be set as true, but right now it's uninitialized. Signed-off-by: Dan Carpenter <> Signed-off-by: Jens Axboe <>
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index b5d843a02bfa..9bc10e31a143 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -1026,7 +1026,8 @@ static void mtip_issue_non_ncq_command(struct mtip_port *port, int tag)
static int mtip_quiesce_io(struct mtip_port *port, unsigned long timeout)
unsigned long to;
- unsigned int n, active;
+ unsigned int n;
+ unsigned int active = 1;
to = jiffies + msecs_to_jiffies(timeout);
do {