path: root/test/cq-overflow.c
diff options
authorJeff Moyer <>2019-11-05 08:39:17 +0100
committerJens Axboe <>2019-11-05 08:13:41 -0700
commit0781f2af2c4837ca01d97329bf9ce718ff202e00 (patch)
treec35ada5827d275d56b7e0ca2c42645be60f4e235 /test/cq-overflow.c
parent9f4714c22c63a967ada9b998b433b5fcb718743f (diff)
spec: Fedora RPM cleanups
Cole Robinson and Fabio Valenti made a number of suggestions for the .spec file: * Release should be Release: 1%{?dist} so the .fcXX bits get appended to the version string * Source: should be a pointer to the upstream URL that hosts the release. In this case I think it should be the ending weirdness is due to github renaming the archive strangely. You might need to pass '-n %{name}-%{name}-%{version}' to %setup/%autosetup to tell it what the extracted archive name is * The %defattr lines should be removed: * The Group: lines should be removed * All the BuildRoot and RPM_BUILD_ROOT lines should be removed. %clean should be removed * The ./configure line should be replaced with just %configure * The 'make' call should be %make_build * The 'make install' call should be %make_install * The %pre and %post sections can be entirely removed, ldconfig is done automatically: * The devel package 'Requires: liburing' should instead be: Requires: %{name} = %{version}-%{release} * The devel package should also have Requires: pkgconfig * I think all the %attr usage can be entirely removed, unless they are doing something that the build system isn't doing. * The Provides: shouldn't be necessary, I'm pretty sure RPM automatically adds annotations like this * Replace %setup with %autosetup, which will automatically apply any listed Patch: in the spec if anything is backported in the future. It's a small maintenace optimization These changes work on Fedora 31 and openSUSE Leap 15.1. Therefore they are likely to work on other rpm-based distributions too. Acked-by: Jeff Moyer <> Tested-by: Stefan Hajnoczi <> Signed-off-by: Stefan Hajnoczi <> Signed-off-by: Jeff Moyer <> Signed-off-by: Jens Axboe <>
Diffstat (limited to 'test/cq-overflow.c')
0 files changed, 0 insertions, 0 deletions