diff options
authorAmmar Faizi <>2022-04-23 03:35:38 +0700
committerJens Axboe <>2022-04-22 15:15:22 -0600
commitc36cd51eef30c81a0ce3398057672f3c03498b86 (patch)
parent2a2e58225cdb9f0c6f86c610c4d2d137a914e41d (diff)
Makefile: Make sure we build everything before runtests
A recent commit added `runtests-parallel` target to run the tests in parallel. But it doesn't have a proper build dependency. As such, when doing: make -j clean; make -j runtests-parallel; we got this error: ``` make[1]: Entering directory '/home/ammarfaizi2/app/liburing/test' make[1]: *** No rule to make target '232c93d07b74.t', needed by '232c93d07b74.run_test'. Stop. make[1]: Leaving directory '/home/ammarfaizi2/app/liburing/test' make: *** [Makefile:25: runtests-parallel] Error 2 ``` Add `all` target as the dependency of `runtests-parallel`. While in there, I found the same issue on `runtests-loop` target. Do the same thing for it too. This way the main Makefile will build everything first before trying to execute the tests. Cc: Dylan Yudaken <> Fixes: 4fb3c9e9c737c2cf2d4df4e1972e68d596a626f7 ("Add runtests-loop target") Fixes: 6480f692d62afbebb088febc369b30a63dbc2ea7 ("test: add make targets for each test") Signed-off-by: Ammar Faizi <> Signed-off-by: Jens Axboe <>
1 files changed, 2 insertions, 2 deletions
diff --git a/Makefile b/Makefile
index d54551e..686be4f 100644
--- a/Makefile
+++ b/Makefile
@@ -19,9 +19,9 @@ partcheck: all
runtests: all
@$(MAKE) -C test runtests
+runtests-loop: all
@$(MAKE) -C test runtests-loop
+runtests-parallel: all
@$(MAKE) -C test runtests-parallel
config-host.mak: configure