summaryrefslogtreecommitdiff
path: root/zbd.c
diff options
context:
space:
mode:
authorDmitry Fomichev <dmitry.fomichev@wdc.com>2021-01-27 13:19:28 +0900
committerJens Axboe <axboe@kernel.dk>2021-01-29 08:14:00 -0700
commit1a8d510a69ea95b8bdc4c05f49f257b7cafddd02 (patch)
tree84894292e958c90155eeb81cd87cdd156db06176 /zbd.c
parented2eb8757093b67c85071de94a10f1e42164b4c6 (diff)
downloadfio-1a8d510a69ea95b8bdc4c05f49f257b7cafddd02.tar.gz
fio-1a8d510a69ea95b8bdc4c05f49f257b7cafddd02.tar.bz2
zbd: avoid failing assertion in zbd_convert_to_open_zone()
The test run against null_blk with the following command line - t/zbd/run-tests-against-nullb -l -q -s 12 -t 51 -n 100 stops with a failure and the message below can be seen in the test log: fio: zbd.c:1110: zbd_convert_to_open_zone: Assertion `open_zone_idx < f->zbd_info->num_open_zones' failed. This assertion fails because pick_random_zone_idx() function returns index 0 if no zones are currently open. In this case, open_zone_idx and f->zbd_info->num_open_zones are both zero. Since this situation is normal, simply modify the assert statement to avoid failing. Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com> Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'zbd.c')
-rw-r--r--zbd.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/zbd.c b/zbd.c
index 1ee238e8..8583f2ac 100644
--- a/zbd.c
+++ b/zbd.c
@@ -1107,7 +1107,8 @@ static struct fio_zone_info *zbd_convert_to_open_zone(struct thread_data *td,
* Ignore zones which don't belong to thread's offset/size area.
*/
open_zone_idx = pick_random_zone_idx(f, io_u);
- assert(open_zone_idx < f->zbd_info->num_open_zones);
+ assert(!open_zone_idx ||
+ open_zone_idx < f->zbd_info->num_open_zones);
tmp_idx = open_zone_idx;
for (i = 0; i < f->zbd_info->num_open_zones; i++) {
uint32_t tmpz;