diff options
author | Bruce Cran <bruce@cran.org.uk> | 2011-01-08 19:49:54 +0100 |
---|---|---|
committer | Jens Axboe <jaxboe@fusionio.com> | 2011-01-08 19:49:54 +0100 |
commit | 9b8365618309572d8fd2579c8ea3132db89f843f (patch) | |
tree | 8b0b266489021c4fef9d52693032241ec1de0207 /os/os-windows.h | |
parent | e4db9fec06d77523472e9fad6de5170a77d715c0 (diff) | |
download | fio-9b8365618309572d8fd2579c8ea3132db89f843f.tar.gz fio-9b8365618309572d8fd2579c8ea3132db89f843f.tar.bz2 |
Various fixes/updates
- Update HOWTO to note that directio and fallocate don't work with ZFS
on Solaris.
Refactor the Makefile's to add CPPFLAGS and LIBS.
- Add -fno-omit-frame-pointer from Linux Makefile to every platform
- Change undefined $(ALL_CFLAGS) to $(CFLAGS)
- Pass -std=gnu99, without which OS X fails to build.
- Add -D__EXTENSIONS__ on Solaris since some functions we need are
behind it.
- Pull in <limits.h> in fio.c to get PTHREAD_STACK_MIN.
- NetBSD doesn't define PTHREAD_STACK_MIN so set it to 4k in
os-netbsd.h
- If we have posix_fallocate don't error out if it fails during mutex
and malloc operations since it will fail on Solaris with a ZFS
filesystem. As I understand it these aren't performance-critical
operations so do they need to be considered critical?
- Remove fio_unused from os-* files since it's defined in fio.h and we
don't really need it.
- FreeBSD has an idprio command but not the API so don't claim it does.
- OS X doesn't have the timer_* API so emulate it using
setitimer/sigaction.
- NetBSD and Solaris don't support CLOCK_MONOTONIC in timer_create so
remove FIO_HAVE_CLOCK_MONOTONIC from their os-* files.
I've noticed that a change I made a while ago to use fmin/fmax could
cause issues on older OSes - I had a CD with NetBSD 5.0.2 and found
they had only been implemented in 5.1 so I'm not sure if I should
revert it.
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Diffstat (limited to 'os/os-windows.h')
-rw-r--r-- | os/os-windows.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/os/os-windows.h b/os/os-windows.h index f7712a17..9edacf33 100644 --- a/os/os-windows.h +++ b/os/os-windows.h @@ -36,8 +36,8 @@ static inline int blockdev_size(struct fio_file *f, unsigned long long *bytes) HANDLE hFile;
if (f->hFile == NULL) {
- hFile = CreateFile(f->file_name, (GENERIC_READ | GENERIC_WRITE),
- (FILE_SHARE_READ | FILE_SHARE_WRITE), NULL, OPEN_EXISTING, 0, NULL);
+ hFile = CreateFile(f->file_name, GENERIC_READ, FILE_SHARE_READ | FILE_SHARE_WRITE,
+ NULL, OPEN_EXISTING, 0, NULL);
} else {
hFile = f->hFile;
}
|