summaryrefslogtreecommitdiff
path: root/debug.h
diff options
context:
space:
mode:
authorAlexey Dobriyan <adobriyan@gmail.com>2020-04-02 22:21:02 +0300
committerJens Axboe <axboe@kernel.dk>2020-04-02 13:33:49 -0600
commit6463db6c1d3a2a961008e87a86d464b596886f1a (patch)
treeaae8ab62b24399f369993f148a00861aceb86290 /debug.h
parent839f607b5771081e96942977a1ff9f1b24b77bca (diff)
downloadfio-master.tar.gz
fio-master.tar.bz2
fio: fix interaction between offset/size limited threads and "max_open_zones"HEADmaster
If thread bumps into "max_open_zones" limit, it tries to close/reopen some other zone before issuing IO. This scan is done over full list of block device's opened zones. It means that a zone which doesn't belong to thread's working area can be altered or IO can be retargeted at such zone. If IO is retargeted then it will be dropped by "is_valid_offset()" check. What happens with null block device testing is that one thread monopolises IO and others threads do basically nothing. This config will reliably succeed now: [global] zonemode=zbd zonesize=1M rw=randwrite ... thread numjobs=2 offset_increment=128M [j] max_open_zones=2 size=2M Starting 2 threads zbd 7991 /dev/nullb0: zbd model string: host-managed zbd 7991 Device /dev/nullb0 has 1024 zones of size 1024 KB zbd 8009 /dev/nullb0: examining zones 0 .. 2 zbd 8010 /dev/nullb0: examining zones 128 .. 130 zbd 8009 /dev/nullb0: opening zone 0 zbd 8010 /dev/nullb0: opening zone 128 zbd 8009 /dev/nullb0: queued I/O (0, 4096) for zone 0 zbd 8009 zbd_convert_to_open_zone(/dev/nullb0): starting from zone 128 (offset 1552384, buflen 4096) retargeted for other thread's zone (zone 0 => zone 128) zbd 8010 /dev/nullb0: queued I/O (134217728, 4096) for zone 128 zbd 8009 zbd_convert_to_open_zone(/dev/nullb0): returning zone 128 zbd 8009 Dropped request with offset 134221824 and dropped Note: quasi-randomness is kind of necessary to spread I/O. Imagine index 0 is picked all the time, zone living there will be reopened constantly and get relatively little I/O. Signed-off-by: Alexey Dobriyan (SK hynix) <adobriyan@gmail.com> Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com> Tested-by: Damien Le Moal <damien.lemoal@wdc.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'debug.h')
0 files changed, 0 insertions, 0 deletions