summaryrefslogtreecommitdiff
path: root/configure
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2021-05-06 17:23:31 +0100
committerJens Axboe <axboe@kernel.dk>2021-05-06 10:24:58 -0600
commitcffe80a41cbf9b26446c803177a27f7695f94a31 (patch)
tree5afb5ff3e2c9628df2f1bbc1a39ce700760eab73 /configure
parent6308ef297145e73add65ba86bfdbeaf967957d1f (diff)
downloadfio-cffe80a41cbf9b26446c803177a27f7695f94a31.tar.gz
fio-cffe80a41cbf9b26446c803177a27f7695f94a31.tar.bz2
configure: fix check_min_lib_version() eval
The following shell statement: if eval "echo \$$_feature" = "yes" ; then executes: echo $... = "yes" It does not actually compare the variable named by $_feature to the string "yes". Add the missing "test" call so the comparison happens as intended and wrap the eval so it doesn't include the = "yes". Fixes: 3e48f7c9de61 ("configure: fix syntax error with NetBSD") Cc: Dmitry Fomichev <dmitry.fomichev@wdc.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'configure')
-rwxr-xr-xconfigure2
1 files changed, 1 insertions, 1 deletions
diff --git a/configure b/configure
index a7d82be0..e886bdc8 100755
--- a/configure
+++ b/configure
@@ -142,7 +142,7 @@ check_min_lib_version() {
fi
: "${_feature:=${1}}"
if "${cross_prefix}"pkg-config --version > /dev/null 2>&1; then
- if eval "echo \$$_feature" = "yes" ; then
+ if test "$(eval echo \"\$$_feature\")" = "yes" ; then
feature_not_found "$_feature" "$1 >= $2"
fi
else