diff options
author | Stefan Hajnoczi <stefanha@redhat.com> | 2021-05-06 17:23:31 +0100 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2021-05-06 10:24:58 -0600 |
commit | cffe80a41cbf9b26446c803177a27f7695f94a31 (patch) | |
tree | 5afb5ff3e2c9628df2f1bbc1a39ce700760eab73 /configure | |
parent | 6308ef297145e73add65ba86bfdbeaf967957d1f (diff) | |
download | fio-cffe80a41cbf9b26446c803177a27f7695f94a31.tar.gz fio-cffe80a41cbf9b26446c803177a27f7695f94a31.tar.bz2 |
configure: fix check_min_lib_version() eval
The following shell statement:
if eval "echo \$$_feature" = "yes" ; then
executes:
echo $... = "yes"
It does not actually compare the variable named by $_feature to the
string "yes".
Add the missing "test" call so the comparison happens as intended and
wrap the eval so it doesn't include the = "yes".
Fixes: 3e48f7c9de61 ("configure: fix syntax error with NetBSD")
Cc: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'configure')
-rwxr-xr-x | configure | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -142,7 +142,7 @@ check_min_lib_version() { fi : "${_feature:=${1}}" if "${cross_prefix}"pkg-config --version > /dev/null 2>&1; then - if eval "echo \$$_feature" = "yes" ; then + if test "$(eval echo \"\$$_feature\")" = "yes" ; then feature_not_found "$_feature" "$1 >= $2" fi else |