diff options
| author | Jens Axboe <axboe@kernel.dk> | 2019-08-03 08:33:24 -0600 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2019-08-03 08:33:24 -0600 |
| commit | 8ca8a05d92fa799fe93a6edc27b058802211fddc (patch) | |
| tree | 8261d247a75e8460acc1787dc7d24087890fac96 | |
| parent | f2d6de5d997b039cebac9c34912871baa5e12d49 (diff) | |
| download | fio-8ca8a05d92fa799fe93a6edc27b058802211fddc.tar.gz fio-8ca8a05d92fa799fe93a6edc27b058802211fddc.tar.bz2 | |
engines/splice: remove buggy ->mem_align set
Two things wrong here:
1) We align buffers by default, so no need for splice to do anything
extra.
2) ->mem_align is not a true/false setting, it's the alignment itself.
Hence the current setting to 1 is just buggy.
Fixes: https://github.com/axboe/fio/issues/810
Reported-by: Sitsofe Wheeler <sitsofe@yahoo.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | engines/splice.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/engines/splice.c b/engines/splice.c index feb764fe..6fc36bb6 100644 --- a/engines/splice.c +++ b/engines/splice.c @@ -278,13 +278,6 @@ static int fio_spliceio_init(struct thread_data *td) */ sd->vmsplice_to_user_map = 1; - /* - * And if vmsplice_to_user works, we definitely need aligned - * buffers. Just set ->odirect to force that. - */ - if (td_read(td)) - td->o.mem_align = 1; - td->io_ops_data = sd; return 0; } |