summaryrefslogtreecommitdiff
path: root/btt/trace_requeue.c
diff options
context:
space:
mode:
authorAlan D. Brunelle <Alan.Brunelle@hp.com>2007-09-10 18:37:49 +0200
committerJens Axboe <jens.axboe@oracle.com>2007-09-10 18:37:49 +0200
commit4c48f14ea8ae2fae86811ac4dc1d72ad9bb601c2 (patch)
tree97a01448fa090ed0aacf979e640bf77e40b637bf /btt/trace_requeue.c
parenta5981e2e795319502cc8dda629482928f3b7b204 (diff)
downloadblktrace-4c48f14ea8ae2fae86811ac4dc1d72ad9bb601c2.tar.gz
blktrace-4c48f14ea8ae2fae86811ac4dc1d72ad9bb601c2.tar.bz2
Major revamping (ver 2.0)
After a lot of fighting with maintaining a tree-styled design (each trace having it's own node), it was just getting too cumbersome to work in all circumstances. Taking a clue from blkparse itself, I decided to just keep track of IOs at queue time, and updating fields based upon later traces. The attached (large) patch works much faster, handles larger test cases with less failures, and is managing some pretty large jobs I'm working on (large Oracle-based DB analysis - 32-way box w/ lots of storage). I've also added a Q2Q seek distance feature - it's come in handy when comparing results of IO scheduler choice: We can see what the incoming IO seek distances are (at queue time), and then see how the scheduler itself manages things (via merges & sorting) by looking at D2D seek distances generated. As noted in the subject, I arbitrarily bumped this to version 2.00 as the innards are so different. The documentation (btt/doc/btt.tex) has been updated to reflect some minor output changes. I also fixed a bug dealing with process name notification: there was a problem that if a new PID came up with a name that was previously seen, btt wouldn't keep track of it right. [When running with Oracle, a lot of processes have the same name but different PIDs of course.] Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'btt/trace_requeue.c')
-rw-r--r--btt/trace_requeue.c21
1 files changed, 1 insertions, 20 deletions
diff --git a/btt/trace_requeue.c b/btt/trace_requeue.c
index 4baf66e..db5f7b7 100644
--- a/btt/trace_requeue.c
+++ b/btt/trace_requeue.c
@@ -22,24 +22,5 @@
void trace_requeue(struct io *r_iop)
{
- struct io *d_iop;
-
- if ((io_setup(r_iop, IOP_R) == 0) ||
- (d_iop = dip_find_sec(r_iop->dip, IOP_D,
- BIT_START(r_iop))) == NULL) {
- io_release(r_iop);
- return;
- }
- dip_rem(d_iop);
-
-# if defined(DEBUG)
- ASSERT(ready_issue(d_iop, r_iop) != 0);
-# else
- (void)ready_issue(d_iop, r_iop);
-# endif
-
- run_unissue(d_iop, r_iop, r_iop);
- add_rmhd(r_iop);
-
- release_iops();
+ io_release(r_iop);
}