diff options
author | Edward Shishkin <edward@redhat.com> | 2010-04-20 15:41:14 +0200 |
---|---|---|
committer | Jens Axboe <jens.axboe@oracle.com> | 2010-04-20 15:41:14 +0200 |
commit | fb7f86674a516ddff0d60bfab3bd284a4812075f (patch) | |
tree | 4332d21f5193f2f843e168196b4e52dcfccbb882 /blktrace.c | |
parent | a8d834fbba5310cfc745aeff463e65ae200eaa8b (diff) | |
download | blktrace-fb7f86674a516ddff0d60bfab3bd284a4812075f.tar.gz blktrace-fb7f86674a516ddff0d60bfab3bd284a4812075f.tar.bz2 |
blktrace: disable kill option - take 2
Fixup for 513950.
Problem:
'blktrace -d <device> -k' does not kill a running
backgound trace. Executing 'blktrace -d <device> -k'
for the second time results in "BLKTRACETEARDOWN:
Invalid argument" message and then each run of
blktrace on that machine prints the following output:
BLKTRACESETUP: No such file or directory.
The bug:
The option -k results in clobbering information
about running trace by kernel (blk_trace_remove),
while resources (files open in debugfs by the running
background blktrace) are not released.
Solution:
Update documentation:
Undocument the non-working "kill" option. Advise
to send SIGINT signall via kill(1) to the running
background blktrace for its correct termination.
Signed-off-by: Edward Shishkin <edward@redhat.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'blktrace.c')
-rw-r--r-- | blktrace.c | 1 |
1 files changed, 0 insertions, 1 deletions
@@ -442,7 +442,6 @@ static char usage_str[] = \ "\t-r Path to mounted debugfs, defaults to /sys/kernel/debug\n" \ "\t-o File(s) to send output to\n" \ "\t-D Directory to prepend to output file names\n" \ - "\t-k Kill a running trace\n" \ "\t-w Stop after defined time, in seconds\n" \ "\t-a Only trace specified actions. See documentation\n" \ "\t-A Give trace mask as a single value. See documentation\n" \ |