blk-mq: fix two misuses on RQF_USE_SCHED
authorMing Lei <ming.lei@redhat.com>
Sat, 24 Jun 2023 13:01:05 +0000 (21:01 +0800)
committerJens Axboe <axboe@kernel.dk>
Sun, 25 Jun 2023 14:01:05 +0000 (08:01 -0600)
commitc6b7a3a26e809c9d2a51ae303764c1d2994f31cf
treec921665f2b85359b6d17a68947868aa8d2a68fb1
parentad7c3b41e86b59943a903d23c7b037d820e6270c
blk-mq: fix two misuses on RQF_USE_SCHED

Request allocated from sched tags can't be issued via ->queue_rqs()
directly, since driver tag isn't allocated yet. This is the 1st misuse
of RQF_USE_SCHED for figuring out plug->has_elevator.

Request allocated from sched tags can't be ended by
blk_mq_end_request_batch() too, fix the 2nd RQF_USE_SCHED misuse
in blk_mq_add_to_batch().

Without this patch, NVMe uring cmd passthrough IO workload can run into
hang easily with real io scheduler.

Fixes: dd6216bb16e8 ("blk-mq: make sure elevator callbacks aren't called for passthrough request")
Reported-by: Guangwu Zhang <guazhang@redhat.com>
Closes: https://lore.kernel.org/linux-block/CAGS2=YrBjpLPOKa-gzcKuuOG60AGth5794PNCDwatdnnscB9ug@mail.gmail.com/
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20230624130105.1443879-1-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq.c
include/linux/blk-mq.h