erofs: fix null-ptr-deref caused by erofs_xattr_prefixes_init
authorJingbo Xu <jefflexu@linux.alibaba.com>
Mon, 15 May 2023 10:39:41 +0000 (18:39 +0800)
committerGao Xiang <hsiangkao@linux.alibaba.com>
Tue, 23 May 2023 08:56:21 +0000 (16:56 +0800)
commit0a17567b4a85243ac1620886b75b3813acde41fc
tree1980cb84da8bbfd20ee88a74f4ecf7cb1780c701
parentf1fcbaa18b28dec10281551dfe6ed3a3ed80e3d6
erofs: fix null-ptr-deref caused by erofs_xattr_prefixes_init

Fragments and dedupe share one feature bit, and thus packed inode may not
exist when fragment feature bit (dedupe feature bit exactly) is set, e.g.
when deduplication feature is in use while fragments feature is not.  In
this case, sbi->packed_inode could be NULL while fragments feature bit
is set.

Fix this by accessing packed inode only when it exists.

Reported-by: syzbot+902d5a9373ae8f748a94@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?extid=902d5a9373ae8f748a94
Reported-and-tested-by: syzbot+bbb353775d51424087f2@syzkaller.appspotmail.com
Fixes: 9e382914617c ("erofs: add helpers to load long xattr name prefixes")
Fixes: 6a318ccd7e08 ("erofs: enable long extended attribute name prefixes")
Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
Reviewed-by: Yue Hu <huyue2@coolpad.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Link: https://lore.kernel.org/r/20230515103941.129784-1-jefflexu@linux.alibaba.com
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
fs/erofs/xattr.c