From df4bf1178ed773986129da6038961388af926971 Mon Sep 17 00:00:00 2001 From: Jens Axboe Date: Fri, 29 Dec 2017 08:45:22 -0700 Subject: [PATCH 1/1] log: fix bad < 0 check for unsigned Fixes: e5f9a813 ("debug: make debug=io readable with multiple threads") Signed-off-by: Jens Axboe --- log.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/log.c b/log.c index 291ff24a..a327f6aa 100644 --- a/log.c +++ b/log.c @@ -98,7 +98,7 @@ void log_prevalist(int type, const char *fmt, va_list args) char pre[32]; char *buffer; size_t len; - size_t prelen; + int prelen; pid_t pid; pid = gettid(); @@ -107,14 +107,11 @@ void log_prevalist(int type, const char *fmt, va_list args) return; prelen = snprintf(pre, sizeof pre, "%-8s %-5u ", debug_levels[type].name, (int) pid); - if (prelen < 0) - return; - - len = prevalist_to_buf(&buffer, pre, prelen, fmt, args); - len = log_info_buf(buffer, len); - free(buffer); - - return; + if (prelen > 0) { + len = prevalist_to_buf(&buffer, pre, prelen, fmt, args); + len = log_info_buf(buffer, len); + free(buffer); + } } size_t log_info(const char *format, ...) -- 2.25.1