From b63fe8bec4c7f5defe6b6842b4d251ecc67add60 Mon Sep 17 00:00:00 2001 From: Tomohiro Kusumi Date: Mon, 12 Jun 2017 23:02:06 +0300 Subject: [PATCH] sg: add missing free(msg); in ->errdetails() handler msg gets malloc'd unconditionally, so we need to free msg if we're not using msg for ret (strdup isn't really needed here to begin with). Signed-off-by: Tomohiro Kusumi Signed-off-by: Jens Axboe --- engines/sg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/engines/sg.c b/engines/sg.c index 2148e87c..9d339bd3 100644 --- a/engines/sg.c +++ b/engines/sg.c @@ -759,8 +759,10 @@ static char *fio_sgio_errdetails(struct io_u *io_u) } } - if (!ret) + if (!ret) { ret = strdup("SG Driver did not report a Host, Driver or Device check"); + free(msg); + } return ret; } -- 2.25.1