From ab43b8cb08d2152e3f15544f8dfd49d7e3e975cc Mon Sep 17 00:00:00 2001 From: Ziye Yang Date: Tue, 29 Oct 2019 22:35:38 +0800 Subject: [PATCH] backend: fix the memory leak if fio_memalign fails, We should not use break, we should use return 1 and explictly fails this, then the cleanup routine will work. If not, this function may still return 0. Signed-off-by: Gang Cao Signed-off-by: Ziye Yang --- backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend.c b/backend.c index fe868271..cb15b0e6 100644 --- a/backend.c +++ b/backend.c @@ -1236,7 +1236,7 @@ static int init_io_u(struct thread_data *td) ptr = fio_memalign(cl_align, sizeof(*io_u), td_offload_overlap(td)); if (!ptr) { log_err("fio: unable to allocate aligned memory\n"); - break; + return 1; } io_u = ptr; -- 2.25.1