From 9d918187e8eceda6637544b7cb0fa3ee734ee5c0 Mon Sep 17 00:00:00 2001 From: Jens Axboe Date: Thu, 23 May 2013 20:00:35 +0200 Subject: [PATCH] Better catch arguments with required options and none passed Signed-off-by: Jens Axboe --- init.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/init.c b/init.c index 0cc6a520..e9e5096a 100644 --- a/init.c +++ b/init.c @@ -1725,7 +1725,13 @@ int parse_cmd_line(int argc, char *argv[], int client_type) fio_options_set_ioengine_opts(l_opts, td); } - ret = fio_cmd_option_parse(td, opt, val); + if ((!val || !strlen(val)) && + l_opts[lidx].has_arg == required_argument) { + log_err("fio: option %s requires an argument\n", opt); + ret = 1; + } else + ret = fio_cmd_option_parse(td, opt, val); + if (ret) { if (td) { put_job(td); -- 2.25.1