From 9b9860651274cfb6e5a367b653e0d465bd89344f Mon Sep 17 00:00:00 2001 From: Jens Axboe Date: Mon, 19 Dec 2011 08:57:18 +0100 Subject: [PATCH] Fix segfault with net io engine and no file/hostname given Signed-off-by: Jens Axboe --- engines/net.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/engines/net.c b/engines/net.c index 6748a3e2..cf6025f1 100644 --- a/engines/net.c +++ b/engines/net.c @@ -702,13 +702,17 @@ static int fio_netio_init(struct thread_data *td) if (o->proto != FIO_TYPE_TCP) { if (o->listen) { - log_err("fio: listen only valid for TCP proto IO\n"); - return 1; + log_err("fio: listen only valid for TCP proto IO\n"); + return 1; } if (td_rw(td)) { - log_err("fio: datagram network connections must be" + log_err("fio: datagram network connections must be" " read OR write\n"); - return 1; + return 1; + } + if (o->proto == FIO_TYPE_UNIX && !td->o.filename) { + log_err("fio: UNIX sockets need host/filename\n"); + return 1; } o->listen = td_read(td); } -- 2.25.1