From 97b32195d4713a13a17d409949fff5a08c4518dd Mon Sep 17 00:00:00 2001 From: Jens Axboe Date: Tue, 11 Nov 2014 08:09:04 -0700 Subject: [PATCH] t/btrace2fio: fix divide-by-zero in rate calculation If usec is less than 1000, it'd crash. Signed-off-by: Jens Axboe --- t/btrace2fio.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/t/btrace2fio.c b/t/btrace2fio.c index bf67ed0a..efe25c4c 100644 --- a/t/btrace2fio.c +++ b/t/btrace2fio.c @@ -546,11 +546,15 @@ static unsigned long o_to_kb_rate(struct btrace_out *o, int rw) uint64_t usec = (o->last_ttime[rw] - o->first_ttime[rw]) / 1000ULL; uint64_t val; + if (!usec) + return 0; + + usec /= 1000; if (!usec) return 0; val = o->kb[rw] * 1000ULL; - return val / (usec / 1000ULL); + return val / usec; } static uint64_t o_first_ttime(struct btrace_out *o) -- 2.25.1