From 5b0a8880e2a0dafbdd12cabcb82f8fe728937e65 Mon Sep 17 00:00:00 2001 From: Jens Axboe Date: Thu, 11 Jan 2007 14:40:27 +0100 Subject: [PATCH] [PATCH] Warn if both option variable offset and callback given If the callback is present, it is preferred to the offsets. So giving offsets with a callback specified doesn't make sense. Signed-off-by: Jens Axboe --- parse.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/parse.c b/parse.c index bc308ffe..2105e2b5 100644 --- a/parse.c +++ b/parse.c @@ -464,7 +464,7 @@ void fill_default_options(void *data, struct fio_option *options) /* * Sanitize the options structure. For now it just sets min/max for bool - * values. + * values and whether both callback and offsets are given. */ void options_init(struct fio_option *options) { @@ -475,5 +475,7 @@ void options_init(struct fio_option *options) o->minval = 0; o->maxval = 1; } + if (o->cb && (o->off1 || o->off2 || o->off3 || o->off4)) + fprintf(stderr, "Option %s: both cb and offset given\n", o->name); } } -- 2.25.1