From 440a5981b37580b3c0f5109bc7f6b5a412ab67fc Mon Sep 17 00:00:00 2001 From: Jens Axboe Date: Fri, 19 Mar 2010 08:08:06 +0100 Subject: [PATCH] Don't call getpid() in dprint() unless we are going to use it Reported-by: David Andersen Signed-off-by: Jens Axboe --- debug.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/debug.h b/debug.h index 71b346d8..891c254e 100644 --- a/debug.h +++ b/debug.h @@ -34,15 +34,16 @@ extern unsigned long fio_debug; #define dprint(type, str, args...) \ do { \ - pid_t pid = getpid(); \ + pid_t __pid; \ assert(type < FD_DEBUG_MAX); \ if ((((1 << type)) & fio_debug) == 0) \ break; \ + __pid = getpid(); \ if (fio_debug_jobp && *fio_debug_jobp != -1U \ - && pid != *fio_debug_jobp) \ + && __pid != *fio_debug_jobp) \ break; \ log_info("%-8s ", debug_levels[(type)].name); \ - log_info("%-5u ", (int) pid); \ + log_info("%-5u ", (int) __pid); \ log_info(str, ##args); \ } while (0) -- 2.25.1