From 1d824f370d9e7fb9fc5aa23bc847c31c8467367a Mon Sep 17 00:00:00 2001 From: Jens Axboe Date: Fri, 11 Apr 2014 11:27:34 -0600 Subject: [PATCH] Fix leak of file descriptor in error path of bc_calc() Signed-off-by: Jens Axboe --- options.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/options.c b/options.c index 5c372b69..9096a322 100644 --- a/options.c +++ b/options.c @@ -3656,8 +3656,10 @@ static char *bc_calc(char *str) return NULL; ret = fread(&buf[tmp - str], 1, 128 - (tmp - str), f); - if (ret <= 0) + if (ret <= 0) { + pclose(f); return NULL; + } pclose(f); buf[(tmp - str) + ret - 1] = '\0'; -- 2.25.1