From 1cc954ba698681c6db247d4fcbec9ea929c42b0f Mon Sep 17 00:00:00 2001 From: Jens Axboe Date: Tue, 10 May 2016 12:15:26 -0600 Subject: [PATCH 1/1] ioengines: cleanup Signed-off-by: Jens Axboe --- ioengines.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/ioengines.c b/ioengines.c index b89a121b..e2e7280a 100644 --- a/ioengines.c +++ b/ioengines.c @@ -22,35 +22,31 @@ static FLIST_HEAD(engine_list); -static int check_engine_ops(struct ioengine_ops *ops) +static bool check_engine_ops(struct ioengine_ops *ops) { if (ops->version != FIO_IOOPS_VERSION) { log_err("bad ioops version %d (want %d)\n", ops->version, FIO_IOOPS_VERSION); - return 1; + return true; } if (!ops->queue) { log_err("%s: no queue handler\n", ops->name); - return 1; + return true; } /* * sync engines only need a ->queue() */ if (ops->flags & FIO_SYNCIO) - return 0; + return false; - if (!ops->event) { - log_err("%s: no event handler\n", ops->name); - return 1; - } - if (!ops->getevents) { - log_err("%s: no getevents handler\n", ops->name); - return 1; + if (!ops->event || !ops->getevents) { + log_err("%s: no event/getevents handler\n", ops->name); + return true; } - return 0; + return false; } void unregister_ioengine(struct ioengine_ops *ops) -- 2.25.1