From 1a889967f9550baa21da2cc3e849a14b5a3daf7b Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tiziano=20M=C3=BCller?= Date: Thu, 3 Jul 2014 18:22:29 +0200 Subject: [PATCH] Bail out if glfs_creat failed Otherwise we will get segfaults from gfapi when it tries to access the invalid fd. Signed-off-by: Jens Axboe --- engines/glusterfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/engines/glusterfs.c b/engines/glusterfs.c index 94daab5a..a64c687f 100644 --- a/engines/glusterfs.c +++ b/engines/glusterfs.c @@ -160,8 +160,9 @@ int fio_gf_open_file(struct thread_data *td, struct fio_file *f) flags & O_RDONLY ? "ro" : "rw", td_read(td) ? "read" : "write"); g->fd = glfs_creat(g->fs, f->file_name, flags, 0644); if (!g->fd) { - log_err("glfs_creat failed.\n"); ret = errno; + log_err("glfs_creat failed.\n"); + return ret; } /* file for read doesn't exist or shorter than required, create/extend it */ if (td_read(td)) { -- 2.25.1