fio.git
7 years agograph: add shading for line graphs
Jens Axboe [Thu, 12 Apr 2012 09:16:17 +0000 (11:16 +0200)]
graph: add shading for line graphs

Pretty simple, just a continually ligher shade of gray off the
top X border, and rightmost Y border.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoFix repeated link of fio
Jens Axboe [Wed, 11 Apr 2012 20:25:26 +0000 (22:25 +0200)]
Fix repeated link of fio

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoMerge branch 'master' into gfio
Jens Axboe [Thu, 5 Apr 2012 14:58:31 +0000 (08:58 -0600)]
Merge branch 'master' into gfio

Conflicts:
fio.c
fio.h

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogroup reporting: fix bad values of min/max
Jens Axboe [Thu, 5 Apr 2012 14:42:11 +0000 (08:42 -0600)]
group reporting: fix bad values of min/max

If you look at the fio output, the group reporting min and max
bandwidth don't match what the actual job reports. This is due
to an error in calculating the min and max values. The aggregate
value is correct, and matches what the job reports.

This did not affect the values that are usually used for reporting,
it's only affecting the group run status output.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoiolog: remove assert in io_u overlap
Jens Axboe [Wed, 4 Apr 2012 20:11:58 +0000 (14:11 -0600)]
iolog: remove assert in io_u overlap

This can happen very rarely for time based jobs. Before we
had this as an assert since it was an impossible to hit
condition, but now it can be expected very rarely with
verify and time based jobs.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoWindows fixes
Bruce Cran [Wed, 4 Apr 2012 14:35:13 +0000 (08:35 -0600)]
Windows fixes

Only return from fio_windowsaio_getevents if the minimum number of IOs has
completed.

Add posix_fallocate implementation to avoid extending the file during the test.

Move call to ResetEvent into windowsaio_getevents where other reset code is
located.

Fix tabs vs. spaces in windowsaio.c and the installer sources.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoFix address truncation on Windows
Bruce Cran [Wed, 4 Apr 2012 00:00:00 +0000 (18:00 -0600)]
Fix address truncation on Windows

Avoid having PAGE_ALIGN truncate addresses by using a pointer-sized
variable for the page size and mask.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoHOWTO: emphasize units in --minimal mode: latency in usec, bw in KB/s
Lucian Adrian Grijincu [Tue, 3 Apr 2012 20:42:48 +0000 (14:42 -0600)]
HOWTO: emphasize units in --minimal mode: latency in usec, bw in KB/s

It wasn't clear what unit were used in --minimal mode.

Signed-off-by: Lucian Adrian Grijincu <lucian@fb.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoMerge branch 'master' into gfio
Jens Axboe [Mon, 2 Apr 2012 16:47:34 +0000 (09:47 -0700)]
Merge branch 'master' into gfio

7 years agoAdd indication of whether a job got killed
Jens Axboe [Mon, 2 Apr 2012 16:47:09 +0000 (09:47 -0700)]
Add indication of whether a job got killed

We have 'X' for exited with error, add 'K' for killed by
signal as well.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoHOWTO: update to note base of latencies in minimal/terse output
Jens Axboe [Mon, 2 Apr 2012 14:03:26 +0000 (07:03 -0700)]
HOWTO: update to note base of latencies in minimal/terse output

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoFixup link of t/ieee754 test
Jens Axboe [Sat, 31 Mar 2012 23:02:08 +0000 (16:02 -0700)]
Fixup link of t/ieee754 test

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agooptions: group tiobench options together
Jens Axboe [Sat, 31 Mar 2012 11:55:54 +0000 (13:55 +0200)]
options: group tiobench options together

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoEnhance the reaped status display
Jens Axboe [Fri, 30 Mar 2012 19:21:20 +0000 (21:21 +0200)]
Enhance the reaped status display

Instead of just printing a '_' for a job that has exited,
allow the user to tell if the job exited with an error or
not. A normally reaped job that ran to completion without
errors will have the '_' displayed. If the job exited with
an error, then an 'X' will be displayed instead.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoDefine SIGUSR1 to inform fio to dump run stats while continuing to run
Jens Axboe [Fri, 30 Mar 2012 08:30:35 +0000 (10:30 +0200)]
Define SIGUSR1 to inform fio to dump run stats while continuing to run

For long running jobs, it may be interesting to see the stats without
having to terminate the job. Set up SIGUSR1 so that it does that,
gives you the stats at that point in time.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoFree disk util on exit, not on stats display
Jens Axboe [Fri, 30 Mar 2012 06:33:27 +0000 (08:33 +0200)]
Free disk util on exit, not on stats display

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agooptions: get rid of more .cb option usage we don't need
Jens Axboe [Thu, 29 Mar 2012 19:17:12 +0000 (21:17 +0200)]
options: get rid of more .cb option usage we don't need

- The lat/bw/iops log does not need two ways of storing whether
  they are enabled or not. Just change the option to a string
  storing variant, and use the existance of a filename to see
  if it's set or not.

- The trim_percentage option need not have a callback, the
  parser knows the limits and can store it appropriately.

- The verify_offset option can express it's minimum value
  directly, it doesn't need a callback to set it on its own.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agooptions: move ioprio/ioprio_class into thread_options space
Jens Axboe [Thu, 29 Mar 2012 06:33:15 +0000 (08:33 +0200)]
options: move ioprio/ioprio_class into thread_options space

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoserver: include number of CPUs in probe reply
Jens Axboe [Wed, 28 Mar 2012 19:38:24 +0000 (21:38 +0200)]
server: include number of CPUs in probe reply

We'll need this for affinity mask setting. Also add room
for flags, we'll want to pass back a flag mask of supported
features on the remote end.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoAdd o->lockmem to conversion functions
Jens Axboe [Wed, 28 Mar 2012 18:52:55 +0000 (20:52 +0200)]
Add o->lockmem to conversion functions

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoMake lockmem a per job option
Jens Axboe [Wed, 28 Mar 2012 18:50:15 +0000 (20:50 +0200)]
Make lockmem a per job option

We need to get rid of per job options that fiddle with global
state. It's confusing, and it breaks remote option handling.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoStart the process of making options more gfio friendly
Jens Axboe [Wed, 28 Mar 2012 12:01:46 +0000 (14:01 +0200)]
Start the process of making options more gfio friendly

We either need to eliminate the option callbacks, or ensure that
they don't have side effects outside of touching td->o. We will
need to use &td->o as the data passed in for the callbacks, not
the full td.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agobackend: ensure that server side releases/frees shm segment on exit
Jens Axboe [Wed, 28 Mar 2012 10:22:40 +0000 (12:22 +0200)]
backend: ensure that server side releases/frees shm segment on exit

We were leaking one for every job run.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agocairo_text_helpers: fix left justified text
Stephen M. Cameron [Wed, 28 Mar 2012 09:02:52 +0000 (11:02 +0200)]
cairo_text_helpers: fix left justified text

Signed-off-by: Stephen M. Cameron <stephenmcameron@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: change job option view
Jens Axboe [Wed, 28 Mar 2012 08:27:42 +0000 (10:27 +0200)]
gfio: change job option view

Instead of having a top notebook containing jobs, and subnotebooks
containing options, have just the one subnotebook and change the
viewed options by selecting the job in a combo box at the top.
This greatly reduces the number of widgets displayed for a big
number of jobs, speeding it up.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoclient: remove command reply after calling into client update_job
Jens Axboe [Wed, 28 Mar 2012 07:15:32 +0000 (09:15 +0200)]
client: remove command reply after calling into client update_job

Ensures that it's definitely processed by the time the client
has waited for it.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoserver: fix bug in going from thread_number to thread
Jens Axboe [Wed, 28 Mar 2012 07:15:05 +0000 (09:15 +0200)]
server: fix bug in going from thread_number to thread

thread_numbers start at 1, not 0.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: start of being able to update options
Jens Axboe [Tue, 27 Mar 2012 14:03:04 +0000 (16:03 +0200)]
gfio: start of being able to update options

Not quite done yet, but it's a start.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoserver: add support for updating job options
Jens Axboe [Tue, 27 Mar 2012 08:06:42 +0000 (10:06 +0200)]
server: add support for updating job options

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoWhite space spring cleaning
Jens Axboe [Tue, 27 Mar 2012 07:12:39 +0000 (09:12 +0200)]
White space spring cleaning

Lets squash them all, with a bit of tooling help.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoprinting: whitespace damage
Jens Axboe [Tue, 27 Mar 2012 06:16:29 +0000 (08:16 +0200)]
printing: whitespace damage

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: Add "print" option for results page.
Stephen M. Cameron [Tue, 27 Mar 2012 06:14:48 +0000 (08:14 +0200)]
gfio: Add "print" option for results page.

It doesn't really print the results page yet, just a kind of test page.

Signed-off-by: Stephen M. Cameron <stephenmcameron@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agograph: factor out cairo text drawing helpers
Stephen M. Cameron [Tue, 27 Mar 2012 06:14:09 +0000 (08:14 +0200)]
graph: factor out cairo text drawing helpers

Signed-off-by: Stephen M. Cameron <stephenmcameron@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoAdd named log level
Jens Axboe [Mon, 26 Mar 2012 19:08:46 +0000 (21:08 +0200)]
Add named log level

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogcompat: gtk_widget_set_can_focus() for below 2.18
Jens Axboe [Mon, 26 Mar 2012 18:31:32 +0000 (20:31 +0200)]
gcompat: gtk_widget_set_can_focus() for below 2.18

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogcompat: gtk_widget_get_window() for below 2.14
Jens Axboe [Mon, 26 Mar 2012 18:27:52 +0000 (20:27 +0200)]
gcompat: gtk_widget_get_window() for below 2.14

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: use appropriate gtk signal for draw/expose of graphs
Jens Axboe [Mon, 26 Mar 2012 17:34:15 +0000 (19:34 +0200)]
gfio: use appropriate gtk signal for draw/expose of graphs

draw on gtk3, expose_event on gtk2.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogcompat: get closer to working with gtk3
Jens Axboe [Mon, 26 Mar 2012 17:30:24 +0000 (19:30 +0200)]
gcompat: get closer to working with gtk3

Just need the draw event now, instead of the expose_event.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogoptions: ensure that gopt_str_multi options get freed
Jens Axboe [Mon, 26 Mar 2012 12:28:36 +0000 (14:28 +0200)]
goptions: ensure that gopt_str_multi options get freed

Was missing the destroy handler.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogoptions: let destroy handler free changed options too
Jens Axboe [Mon, 26 Mar 2012 12:25:26 +0000 (14:25 +0200)]
goptions: let destroy handler free changed options too

We can't touch the memory in the destroy handler, since it could
already have been freed. Just always leave the freeing of option
memory to the destructors.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogcompat: provide backwards compatible functions for older gtk versions
Jens Axboe [Mon, 26 Mar 2012 11:51:11 +0000 (13:51 +0200)]
gcompat: provide backwards compatible functions for older gtk versions

Attempt to do something that'll work equally well across gtk versions,
to improve the supported range.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: use G_OBJECT(), not GTK_OBJECT()
Jens Axboe [Mon, 26 Mar 2012 10:55:33 +0000 (12:55 +0200)]
gfio: use G_OBJECT(), not GTK_OBJECT()

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogoptions: fix check button storaage for FIO_OPT_STR_MULTI
Jens Axboe [Mon, 26 Mar 2012 10:38:33 +0000 (12:38 +0200)]
goptions: fix check button storaage for FIO_OPT_STR_MULTI

i was not incremented...

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogoptions: handle changing of options in job edit
Jens Axboe [Mon, 26 Mar 2012 10:18:23 +0000 (12:18 +0200)]
goptions: handle changing of options in job edit

Track what options have changed, and store them into the
options structure that we have for the given job.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogoptions: use gopt->gjv for option hiding
Jens Axboe [Sat, 24 Mar 2012 19:35:16 +0000 (20:35 +0100)]
goptions: use gopt->gjv for option hiding

We can't rely on gui_data for the gjv lookup, since it'll be
different for each job tab. Instead use the cached value
in the gopt structure, since that is allocate for each client.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogoptions: don't override gopt dep tree by mistake
Jens Axboe [Sat, 24 Mar 2012 19:25:33 +0000 (20:25 +0100)]
goptions: don't override gopt dep tree by mistake

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: add per-job option view
Jens Axboe [Sat, 24 Mar 2012 19:22:29 +0000 (20:22 +0100)]
gfio: add per-job option view

The option view is now a master notebook of jobs that got added
from a given job file, with each tab holding a new notebook
with tabs for the options.

This is pretty slow for big jobs. Adding eg the 1mbs-clients.fio
example job file shows this nicely, since it contains 32 jobs.
Will need to look into how to speed this up.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: start of per-job option edit
Jens Axboe [Sat, 24 Mar 2012 07:56:50 +0000 (08:56 +0100)]
gfio: start of per-job option edit

Currently we don't properly handle job files with multiple
job entries in them, each one just overwrites the last.
Start tracking all of them.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agostat: move final \n of terse output to the end
Jens Axboe [Fri, 23 Mar 2012 18:22:21 +0000 (19:22 +0100)]
stat: move final \n of terse output to the end

Don't print a new line, description, then another new line.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoAdd regression test for ae2fafc8
Jens Axboe [Fri, 23 Mar 2012 12:43:19 +0000 (13:43 +0100)]
Add regression test for ae2fafc8

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoverify: verify bytes should not add to this_io_bytes
webee [Fri, 23 Mar 2012 12:41:41 +0000 (13:41 +0100)]
verify: verify bytes should not add to this_io_bytes

When rw=readwrite,verify+backlog, the verify are treated as normal
read, and bytes are added to this_io_bytes, cause fio terminate early.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoAllow readwrite as an alias for rw in setting sequential read/write
Jens Axboe [Fri, 23 Mar 2012 12:40:06 +0000 (13:40 +0100)]
Allow readwrite as an alias for rw in setting sequential read/write

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoclient: use eta msec as the poll interval
Jens Axboe [Fri, 23 Mar 2012 12:19:31 +0000 (13:19 +0100)]
client: use eta msec as the poll interval

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoserver: idle a bit more of we are not expecting work
Jens Axboe [Fri, 23 Mar 2012 11:25:18 +0000 (12:25 +0100)]
server: idle a bit more of we are not expecting work

Don't wakeup every 100msec if we are not expecting an event
that wont already wakes up poll() automatically.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: improve and remember font selection
Jens Axboe [Fri, 23 Mar 2012 09:52:25 +0000 (10:52 +0100)]
gfio: improve and remember font selection

Redraw/expose doesn't quite work yet, though.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agograph: indentation fixup
Jens Axboe [Fri, 23 Mar 2012 07:18:57 +0000 (08:18 +0100)]
graph: indentation fixup

Use tabs, not spaces.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoFix reversal of IOPS and BW graphs
Jens Axboe [Fri, 23 Mar 2012 07:15:46 +0000 (08:15 +0100)]
Fix reversal of IOPS and BW graphs

Commit 8dfd6071 inadvertently mixed them up, restore original
behaviour.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoFio 2.0.6 fio-2.0.6
Jens Axboe [Fri, 23 Mar 2012 07:09:44 +0000 (08:09 +0100)]
Fio 2.0.6

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoFix terse output with description set
Vikram Seth [Fri, 23 Mar 2012 07:09:09 +0000 (08:09 +0100)]
Fix terse output with description set

I have seen that using 2.05 version of fio the terse output formatting
has an issue when there is a text description given in the test file.
There is no newline separating the description and the next job stats.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: make completion percentiles graphs expand to window width
Stephen M. Cameron [Fri, 23 Mar 2012 06:49:05 +0000 (07:49 +0100)]
gfio: make completion percentiles graphs expand to window width

Signed-off-by: Stephen M. Cameron <stephenmcameron@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: make completion percentiles boxes expand to container width
Stephen M. Cameron [Fri, 23 Mar 2012 06:49:02 +0000 (07:49 +0100)]
gfio: make completion percentiles boxes expand to container width

Signed-off-by: Stephen M. Cameron <stephenmcameron@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: make io depths expand to window width
Stephen M. Cameron [Fri, 23 Mar 2012 06:48:52 +0000 (07:48 +0100)]
gfio: make io depths expand to window width

Signed-off-by: Stephen M. Cameron <stephenmcameron@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: make latency buckets expand to window width
Stephen M. Cameron [Fri, 23 Mar 2012 06:48:37 +0000 (07:48 +0100)]
gfio: make latency buckets expand to window width

Signed-off-by: Stephen M. Cameron <stephenmcameron@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agograph: return opaque graph_label_t for each label added
Jens Axboe [Thu, 22 Mar 2012 21:10:37 +0000 (22:10 +0100)]
graph: return opaque graph_label_t for each label added

Gets rid of the strcmp() lookup, store the graph label locally
instead and just pass that in.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: leave notebook entry as the file name
Jens Axboe [Thu, 22 Mar 2012 20:42:55 +0000 (21:42 +0100)]
gfio: leave notebook entry as the file name

We have the job name(s) in the combo box already, it's nicer to
just leave the tab as the filename.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoFixes for 32-bit compile
Jens Axboe [Thu, 22 Mar 2012 20:31:00 +0000 (21:31 +0100)]
Fixes for 32-bit compile

- uint32/64 casting
- Real bug fix in types[] index beyond length.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: hide graph if all values are zero
Jens Axboe [Thu, 22 Mar 2012 20:21:00 +0000 (21:21 +0100)]
gfio: hide graph if all values are zero

If all visible data points in a label are zero, don't display it
and don't show tooltips.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agograph: fix finding tooltips from label 1+
Jens Axboe [Thu, 22 Mar 2012 19:48:02 +0000 (20:48 +0100)]
graph: fix finding tooltips from label 1+

Only break if we actually found a tooltip, not unconditionally.
Cleanups.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agograph: fix missing else
Jens Axboe [Thu, 22 Mar 2012 08:33:33 +0000 (09:33 +0100)]
graph: fix missing else

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agograph: prio tree alias handling
Jens Axboe [Thu, 22 Mar 2012 08:24:05 +0000 (09:24 +0100)]
graph: prio tree alias handling

Store aliases in a list off the prio node.

Switch graph internals to use flist, instead of home brew list.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoMake fio include the git version in the version output
Jens Axboe [Wed, 21 Mar 2012 21:25:22 +0000 (22:25 +0100)]
Make fio include the git version in the version output

Makes it easier in bug reporting, don't have to ask people what
they are running...

Here's to you, Kep.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agograph: remove unnecessary float multiplier
Jens Axboe [Wed, 21 Mar 2012 21:00:43 +0000 (22:00 +0100)]
graph: remove unnecessary float multiplier

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agograph: yet one tooltip tweaking
Jens Axboe [Wed, 21 Mar 2012 20:55:21 +0000 (21:55 +0100)]
graph: yet one tooltip tweaking

Don't use a percentage of the data value as the check point, that
makes it increasingly difficult to pin point a tooltip for a graph
that is near the bottom end of the range. Instead use a fixed
percentage of the first tickmark, that makes it equally fair
across the range.

Also switch to using the X axis as the prio tree index, since that
should be increasing nicely all the time.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agograph: bump prio end value by ytick delta, if all zeroes
Jens Axboe [Wed, 21 Mar 2012 19:20:35 +0000 (20:20 +0100)]
graph: bump prio end value by ytick delta, if all zeroes

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agograph: cleanup tooltip alias handling
Jens Axboe [Wed, 21 Mar 2012 18:53:32 +0000 (19:53 +0100)]
graph: cleanup tooltip alias handling

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agograph: fix crash on alias in prio tree
Jens Axboe [Wed, 21 Mar 2012 18:48:32 +0000 (19:48 +0100)]
graph: fix crash on alias in prio tree

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agograph: clear prio root iter on extra loop
Jens Axboe [Wed, 21 Mar 2012 18:33:32 +0000 (19:33 +0100)]
graph: clear prio root iter on extra loop

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agograph: fix for unitialized graph_value nodes
Jens Axboe [Wed, 21 Mar 2012 17:54:30 +0000 (18:54 +0100)]
graph: fix for unitialized graph_value nodes

And leaking tooltip/node on free.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agograph: remove debug printf
Jens Axboe [Wed, 21 Mar 2012 16:18:46 +0000 (17:18 +0100)]
graph: remove debug printf

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agograph: switch tooltip lookups to being range based in a prio tree
Jens Axboe [Wed, 21 Mar 2012 16:17:45 +0000 (17:17 +0100)]
graph: switch tooltip lookups to being range based in a prio tree

This cuts a lot of the CPU usage from browsing bigger graphs. Even
the normal graphs are typically cut in half.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoMove rbtree into lib/
Jens Axboe [Wed, 21 Mar 2012 13:07:11 +0000 (14:07 +0100)]
Move rbtree into lib/

And make ARRAY_SIZE() generally available, also outside gfio.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agograph: stop matching tooltips if X diff is too large
Jens Axboe [Wed, 21 Mar 2012 12:36:46 +0000 (13:36 +0100)]
graph: stop matching tooltips if X diff is too large

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: set notebook label to base filename
Jens Axboe [Wed, 21 Mar 2012 11:55:49 +0000 (12:55 +0100)]
gfio: set notebook label to base filename

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: use glib hash for tab lookup
Jens Axboe [Wed, 21 Mar 2012 11:48:32 +0000 (12:48 +0100)]
gfio: use glib hash for tab lookup

Not really a CPU saver, but it reduces the amount of code we have
to maintain by getting rid of the list lookup.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: fix gc leak
Jens Axboe [Wed, 21 Mar 2012 11:02:13 +0000 (12:02 +0100)]
gfio: fix gc leak

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: fixup spurious editor indent
Jens Axboe [Wed, 21 Mar 2012 10:59:18 +0000 (11:59 +0100)]
gfio: fixup spurious editor indent

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: split some parts into gclient.c
Jens Axboe [Wed, 21 Mar 2012 10:13:31 +0000 (11:13 +0100)]
gfio: split some parts into gclient.c

We'll probably want to split gclient.c into op code handling and
results display/view.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: add gerror.c for reporting errors
Jens Axboe [Wed, 21 Mar 2012 09:25:29 +0000 (10:25 +0100)]
gfio: add gerror.c for reporting errors

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: update for handling files, connections, states
Jens Axboe [Wed, 21 Mar 2012 09:15:20 +0000 (10:15 +0100)]
gfio: update for handling files, connections, states

Big update, changes:

- Notify from client helpers when a client is removed. This helps
  gfio track this.

- Make the connection states more bullet proof. You can now connect
  and disconnect, and expect connect to work again.

- Limit number of files opened through file selection or drag'n drop
  to just 1.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoclient: don't leak file descriptor on exit
Jens Axboe [Tue, 20 Mar 2012 14:15:00 +0000 (15:15 +0100)]
client: don't leak file descriptor on exit

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agoserver: use passed in sk in send functions
Jens Axboe [Tue, 20 Mar 2012 13:35:35 +0000 (14:35 +0100)]
server: use passed in sk in send functions

It's not always server_fd, for client communication it's the
client fd.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogfio: lessen use of main_ui directly
Jens Axboe [Tue, 20 Mar 2012 11:25:36 +0000 (12:25 +0100)]
gfio: lessen use of main_ui directly

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogoptions: remember to mark option index for FIO_OPT_STR_VAL
Jens Axboe [Tue, 20 Mar 2012 11:09:13 +0000 (12:09 +0100)]
goptions: remember to mark option index for FIO_OPT_STR_VAL

Fixes hiding of these options.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogoptions: use glib n-ary tree for option dependencies
Jens Axboe [Tue, 20 Mar 2012 10:29:09 +0000 (11:29 +0100)]
goptions: use glib n-ary tree for option dependencies

We didn't support looking up children of children before, since
it would just be too costly (making the whole 'visible' thing
be N!). Move to a glib n-ary tree for option dependencies, this
is a lot cleaner and faster.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogoptions: enable combo box hiding
Jens Axboe [Tue, 20 Mar 2012 09:29:45 +0000 (10:29 +0100)]
goptions: enable combo box hiding

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agooptions: add ->hide_on_set
Jens Axboe [Tue, 20 Mar 2012 09:19:44 +0000 (10:19 +0100)]
options: add ->hide_on_set

Normally we hide children if the parent isn't set, but for some
options it's the other way around.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogoptions: don't emit change signals during setup
Jens Axboe [Tue, 20 Mar 2012 09:05:38 +0000 (10:05 +0100)]
goptions: don't emit change signals during setup

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogoptions: ensure that FIO_OPT_STR_VAL doesn't exceed max multiplier
Jens Axboe [Tue, 20 Mar 2012 08:49:49 +0000 (09:49 +0100)]
goptions: ensure that FIO_OPT_STR_VAL doesn't exceed max multiplier

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogoptions: better support for FIO_OPT_STR_VAL
Jens Axboe [Tue, 20 Mar 2012 08:32:35 +0000 (09:32 +0100)]
goptions: better support for FIO_OPT_STR_VAL

Split the value into two components, an integer 0-1023 value
and a combo box with a b/kb/gb/tb/etc multiplier.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 years agogoptions: free opt types on exit from edit options view
Jens Axboe [Tue, 20 Mar 2012 07:31:29 +0000 (08:31 +0100)]
goptions: free opt types on exit from edit options view

Signed-off-by: Jens Axboe <axboe@kernel.dk>