fio.git
12 years agoAdd support for 'bssplit' option, fine grained block size contrl
Jens Axboe [Fri, 14 Dec 2007 11:21:19 +0000 (12:21 +0100)]
Add support for 'bssplit' option, fine grained block size contrl

From the HOWTO addition:

bssplit=str Sometimes you want even finer grained control of the
block sizes issued, not just an even split between them.
This option allows you to weight various block sizes,
so that you are able to define a specific amount of
block sizes issued. The format for this option is:

bssplit=blocksize/percentage:blocksize/percentage

for as many block sizes as needed. So if you want to define
a workload that has 50% 64k blocks, 10% 4k blocks, and
40% 32k blocks, you would write:

bssplit=4k/10:64k/50:32k/40

Ordering does not matter. If the percentage is left blank,
fio will fill in the remaining values evenly. So a bssplit
option like this one:

bssplit=4k/50:1k/:32k/

would have 50% 4k ios, and 25% 1k and 32k ios. The percentages
always add up to 100, if bssplit is given a range that adds
up to more, it will error out.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years ago'1' is minimum value for queue depth, don't allow 0
Jens Axboe [Wed, 12 Dec 2007 18:42:13 +0000 (19:42 +0100)]
'1' is minimum value for queue depth, don't allow 0

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agosyslet: we have fls(), use it for rounding ring size up
Jens Axboe [Wed, 12 Dec 2007 18:39:59 +0000 (19:39 +0100)]
syslet: we have fls(), use it for rounding ring size up

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agounsigned vs signed warnings
Jens Axboe [Tue, 11 Dec 2007 12:23:27 +0000 (13:23 +0100)]
unsigned vs signed warnings

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agosyslet: can't free the stack
Jens Axboe [Tue, 11 Dec 2007 11:36:41 +0000 (12:36 +0100)]
syslet: can't free the stack

Need to check up on this...

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoChange io engine version
Jens Axboe [Tue, 11 Dec 2007 09:54:26 +0000 (10:54 +0100)]
Change io engine version

Minor change from V7, just the getevents() prototype.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years ago->getevents() should take unsigned args
Jens Axboe [Tue, 11 Dec 2007 09:49:39 +0000 (10:49 +0100)]
->getevents() should take unsigned args

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agosyslet: cleanup event reaping
Jens Axboe [Tue, 11 Dec 2007 09:45:36 +0000 (10:45 +0100)]
syslet: cleanup event reaping

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agosyslet: add proper read barrier between user_tail and completion read
Jens Axboe [Tue, 11 Dec 2007 07:55:53 +0000 (08:55 +0100)]
syslet: add proper read barrier between user_tail and completion read

Also fixup a bug with ring indexing, it needs to use the real ring size
mask, not the io depth.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agosyslet: error handling
Jens Axboe [Tue, 11 Dec 2007 07:46:16 +0000 (08:46 +0100)]
syslet: error handling

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agosyslet: make sure ring buffer is a power-of-2
Jens Axboe [Tue, 11 Dec 2007 07:22:53 +0000 (08:22 +0100)]
syslet: make sure ring buffer is a power-of-2

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agosyslet: memory allocation error handling
Jens Axboe [Mon, 10 Dec 2007 19:35:10 +0000 (20:35 +0100)]
syslet: memory allocation error handling

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoAdd kcompat.h
Jens Axboe [Mon, 10 Dec 2007 19:25:24 +0000 (20:25 +0100)]
Add kcompat.h

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agosyslet: update to -v7 as posted by Zach
Jens Axboe [Mon, 10 Dec 2007 19:24:44 +0000 (20:24 +0100)]
syslet: update to -v7 as posted by Zach

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoFix failure in opening files with O_NOATIME
Aaron Carroll [Mon, 26 Nov 2007 08:08:53 +0000 (09:08 +0100)]
Fix failure in opening files with O_NOATIME

If we try to open a file with O_NOATIME and it fails, turn off
O_NOATIME and try again.  This occurs if the user does not own
the file and is unprivileged.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoUpdate HOWTO terse description
Shawn Lewis [Wed, 21 Nov 2007 08:38:34 +0000 (09:38 +0100)]
Update HOWTO terse description

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agofix utime_since overflow
Shawn Lewis [Wed, 21 Nov 2007 08:38:13 +0000 (09:38 +0100)]
fix utime_since overflow

utime_since was using a long for its return which overflows when the difference
between times is more than about 35 minutes.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agodon't log iopiece when do_verify is off
Shawn Lewis [Wed, 21 Nov 2007 08:35:41 +0000 (09:35 +0100)]
don't log iopiece when do_verify is off

Don't log an iopiece if do_verify is off. This allows us to do large write
phases (with verify headers) without using a lot of memory.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agofio.1: minor fixes
Aaron Carroll [Fri, 16 Nov 2007 11:12:45 +0000 (12:12 +0100)]
fio.1: minor fixes

 - Document reading job files from stdin with `-';
 - Fix a typo and remove a spurious line.

Signed-off-by: Aaron Carroll <aaronc@gelato.unsw.edu.au>
Signed-off-by: Jens Axboe <axboe@carl.home.kernel.dk>
12 years agoSeperate ioprio value from setting
Jens Axboe [Thu, 8 Nov 2007 07:29:07 +0000 (08:29 +0100)]
Seperate ioprio value from setting

Newer kernels allow passing a value of '0' for resetting ioprio,
and our check for if (td->ioprio) doesn't allow passing a value of
0 into sys_ioprio_set(). So seperate the setting from the value by
adding a ->ioprio_set bool.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoFio 1.17.2 fio-1.17.2
Jens Axboe [Tue, 30 Oct 2007 14:45:12 +0000 (15:45 +0100)]
Fio 1.17.2

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoFix spurious eta output
Aaron Carroll [Fri, 26 Oct 2007 09:10:28 +0000 (11:10 +0200)]
Fix spurious eta output

 - Pad eta output with enough spaces to overwrite remaining characters
   from the end of previous lines;
 - Wrap an overly-long line.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoMore cpu engine fixes
Jens Axboe [Thu, 25 Oct 2007 16:44:45 +0000 (18:44 +0200)]
More cpu engine fixes

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoMerge branch 'master' of ssh://git.kernel.dk/data/git/fio
Jens Axboe [Thu, 25 Oct 2007 16:34:14 +0000 (18:34 +0200)]
Merge branch 'master' of ssh://git.kernel.dk/data/git/fio

12 years agoFixes for CPU burn engine
Jens Axboe [Thu, 25 Oct 2007 16:34:02 +0000 (18:34 +0200)]
Fixes for CPU burn engine

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoAdd pread/pwrite support to sync engine
gurudas pai [Tue, 23 Oct 2007 13:12:30 +0000 (15:12 +0200)]
Add pread/pwrite support to sync engine

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agofio: build warning fix on gcc-3.4.6-3
gurudas pai [Mon, 22 Oct 2007 20:10:39 +0000 (22:10 +0200)]
fio: build warning fix on  gcc-3.4.6-3

On gcc-3.4.6-3

 >make log.o
gcc -W -Wwrite-strings -Wall -D_GNU_SOURCE -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 -O2 -g  -D_FORTIFY_SOURCE=2 -rdynamic  -c -o
log.o log.c
log.c: In function `read_iolog':
log.c:308: warning: int format, fio_ddir arg (arg 3)

Which corresponds to

enum fio_ddir rw;
..
..
if (sscanf(p, "%d,%llu,%u", &rw, &offset, &bytes) != 3) {

Following patch will fix the warning. This was added by commit
21bd2987dc5d82a18af485cd1e7841e94137fc0c

Thanks,
-Guru

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agosplice: fix fallback from copy vmsplice to nothing
Jens Axboe [Tue, 16 Oct 2007 07:44:47 +0000 (09:44 +0200)]
splice: fix fallback from copy vmsplice to nothing

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agosplice: fix problem with current mainline kernels
Jens Axboe [Tue, 16 Oct 2007 07:42:40 +0000 (09:42 +0200)]
splice: fix problem with current mainline kernels

splice was updated to work well with the newer vmsplice patches,
where we don't have to copy data at all. But that broke the
regular vmsplice that copies data, which is all the mainline kernel
still support.

Fix that up, so we do appropriate fallbacks. Fixes the problem
reported by gurudas pai <gurudas.pai@oracle.com>

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoSet O_NOATIME on open for non-regular files
Jens Axboe [Thu, 11 Oct 2007 19:41:41 +0000 (21:41 +0200)]
Set O_NOATIME on open for non-regular files

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agofio HOWTO/man fix
gurudas pai [Fri, 5 Oct 2007 11:20:18 +0000 (13:20 +0200)]
fio HOWTO/man fix

If I use ioengine=cpu , fio errors out, I referred HOWTO and man pages,
both  says use "cpu" for cpu load. Looked at the code it should be
ioengine=cpuio.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoGet rid of syslet-rw compile warnings on 32-bit
Jens Axboe [Fri, 28 Sep 2007 06:48:52 +0000 (08:48 +0200)]
Get rid of syslet-rw compile warnings on 32-bit

The fixed size API repeatedly warns on the pointer to integer
of different size cast, so sneak an unsigned long conversion in
first. Makes gcc happy and should always be ok.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoDon't use seeks on stdin for job file parsing
Jens Axboe [Thu, 27 Sep 2007 08:48:55 +0000 (10:48 +0200)]
Don't use seeks on stdin for job file parsing

The previous commit added the support for reading a job file
from stdin, but this breaks when fio uses fgetpos/fsetpos on
the file handle. So remove the seeking.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoAdd support for `-' file to read from stdin
Aaron Carroll [Thu, 27 Sep 2007 07:03:55 +0000 (09:03 +0200)]
Add support for `-' file to read from stdin

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoUpdate syslet-rw to fixed size ABI structures
Zach Brown [Tue, 18 Sep 2007 23:28:48 +0000 (16:28 -0700)]
Update syslet-rw to fixed size ABI structures

The syslet system calls moved to using fixed size members of structures.  This
updates the syslet-rw engine to match.  syslet.h was copied from the kernel and
then uXX was replaced with uintXX_T.  Casts were added to move between integers
and pointers.

Signed-off-by: Zach Brown <zach.brown@oracle.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoExec the getpid atom when testing for syslet support
Zach Brown [Wed, 19 Sep 2007 06:42:19 +0000 (08:42 +0200)]
Exec the getpid atom when testing for syslet support

Signed-off-by: Zach Brown <zach.brown@oracle.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoInitialize the new_thread_stack so syslet support testing has one
Zach Brown [Wed, 19 Sep 2007 06:42:18 +0000 (08:42 +0200)]
Initialize the new_thread_stack so syslet support testing has one

Signed-off-by: Zach Brown <zach.brown@oracle.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoTrivial spelling correction
Zach Brown [Wed, 19 Sep 2007 06:42:17 +0000 (08:42 +0200)]
Trivial spelling correction

Signed-off-by: Zach Brown <zach.brown@oracle.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoUpdate syslet system call numbers
Zach Brown [Wed, 19 Sep 2007 06:42:16 +0000 (08:42 +0200)]
Update syslet system call numbers

System calls have been added to mainline while syslets has been pending.

Signed-off-by: Zach Brown <zach.brown@oracle.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoGeneral fio.1 improvements
Aaron Carroll [Tue, 18 Sep 2007 06:10:57 +0000 (08:10 +0200)]
General fio.1 improvements

 - Fixed a bunch of typos and formatting errors.

 - Wrapped some overly-long lines.

 - Added a few new default parameter values.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoman 1 fio
Aaron Carroll [Mon, 17 Sep 2007 08:32:59 +0000 (10:32 +0200)]
man 1 fio

I have put together a draft man page for fio.  The contents are from
fio's HOWTO and README documents and edited for brevity and the odd
typo.  The point is not to replace the existing docmentation, but to
serve as a quick reference.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoAdd ETA output control and interactivity check
Aaron Carroll [Fri, 14 Sep 2007 07:49:41 +0000 (09:49 +0200)]
Add ETA output control and interactivity check

 - Real-time ETA display is only printed if output is to a terminal.

 - Accordingly, add --eta=always|never|auto option.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoFull readonly check
Jens Axboe [Wed, 12 Sep 2007 11:12:39 +0000 (13:12 +0200)]
Full readonly check

Both in core and in engines. To the extent possible, this should catch
even fio errors.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoExtend --readonly
Jens Axboe [Wed, 12 Sep 2007 06:18:36 +0000 (08:18 +0200)]
Extend --readonly

- Never allow open of a data file with writeable bits sets, and that
  includes extend as well.

- Skip any writes in replay logs (iolog/iolog2/blktrace)

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoAdd --readonly option
Jens Axboe [Tue, 11 Sep 2007 18:02:05 +0000 (20:02 +0200)]
Add --readonly option

Suggested by Valerie Henson. It can be used as an extra safety guard
against accidentically turning on a write setting. See README.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agosplice: update to new vmsplice-to-user interface
Jens Axboe [Fri, 7 Sep 2007 18:36:08 +0000 (20:36 +0200)]
splice: update to new vmsplice-to-user interface

I changed the kernel bits (they aren't merged yet), so update
the fio splice engine to reflect that.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoAdd display of major and minor faults
Jens Axboe [Fri, 7 Sep 2007 18:33:33 +0000 (20:33 +0200)]
Add display of major and minor faults

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoVerify handlers should return Exxx error, not just 1
Jens Axboe [Thu, 6 Sep 2007 14:16:44 +0000 (16:16 +0200)]
Verify handlers should return Exxx error, not just 1

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoFix splice engine compile
Jens Axboe [Wed, 5 Sep 2007 16:10:11 +0000 (18:10 +0200)]
Fix splice engine compile

We need to move the splice_unmap_io_u() function.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agosplice engine: add unmapping for vmsplice-to-user
Jens Axboe [Tue, 4 Sep 2007 13:19:59 +0000 (15:19 +0200)]
splice engine: add unmapping for vmsplice-to-user

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoAdd unmap hook that belongs to the IO engines
Jens Axboe [Tue, 4 Sep 2007 13:17:09 +0000 (15:17 +0200)]
Add unmap hook that belongs to the IO engines

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoType in SPLICE_F_UNMAP ifdef
Jens Axboe [Tue, 4 Sep 2007 13:16:39 +0000 (15:16 +0200)]
Type in SPLICE_F_UNMAP ifdef

Should be an ifndef obviously, not ifdef.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoFix eta for pure read workload with verify enabled
Jens Axboe [Tue, 4 Sep 2007 10:38:28 +0000 (12:38 +0200)]
Fix eta for pure read workload with verify enabled

Verify doubles the expected IO count, but that is only true if
we are first writing a file and then reading it back to verify.
If the workload running is just reading back data to verify it,
the IO count is already correct.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoFio 1.17.1 fio-1.17.1
Jens Axboe [Mon, 3 Sep 2007 08:26:54 +0000 (10:26 +0200)]
Fio 1.17.1

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoFix ETA display for iolog replay
Jens Axboe [Mon, 3 Sep 2007 08:09:37 +0000 (10:09 +0200)]
Fix ETA display for iolog replay

Valerie Henson reported (and supplied a patch) to fix the issue with
ETA display not being anywhere near correct when replaying an iolog.
Fix this by ensuring that td->total_io_size is always set correctly.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoAdjust file layout printf
Jens Axboe [Fri, 24 Aug 2007 08:24:09 +0000 (10:24 +0200)]
Adjust file layout printf

Make it file(s) not files, there may be 1 or many.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoStyle fixup
Jens Axboe [Thu, 23 Aug 2007 07:03:38 +0000 (09:03 +0200)]
Style fixup

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoblktrace: skip notify traces
Jens Axboe [Thu, 23 Aug 2007 07:03:26 +0000 (09:03 +0200)]
blktrace: skip notify traces

Fio will not interpret them correctly, resulting in weird behaviour
(like replaying that seems to hang, but is merely just waiting for a
very long time).

Fixes the issue reported by Joshua Root.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoclat/slat display improvements
Jens Axboe [Thu, 16 Aug 2007 11:07:46 +0000 (13:07 +0200)]
clat/slat display improvements

If the avg and min are small, we'll display in usec. But that can make
the max hard to read, so convert min/max to strings like we do for
other values.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoREADME: correct command line description
Jens Axboe [Wed, 15 Aug 2007 07:32:21 +0000 (09:32 +0200)]
README: correct command line description

You can do anything on the command line, it's not limited.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agosplice: automatically detect whether vmsplice-to-user works
Jens Axboe [Tue, 14 Aug 2007 11:43:05 +0000 (13:43 +0200)]
splice: automatically detect whether vmsplice-to-user works

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoFio 1.17 fio-1.17
Jens Axboe [Tue, 14 Aug 2007 08:23:44 +0000 (10:23 +0200)]
Fio 1.17

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoAllow upper-case 'X' for hexidecimal in parser
Jens Axboe [Fri, 10 Aug 2007 12:03:20 +0000 (14:03 +0200)]
Allow upper-case 'X' for hexidecimal in parser

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoRemove verify_pattern option, replace with verify=pattern:x
Jens Axboe [Fri, 10 Aug 2007 11:56:08 +0000 (13:56 +0200)]
Remove verify_pattern option, replace with verify=pattern:x

Integrate the pattern verification with the other verify types,
it's much cleaner that way.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoMark do_verify and verify_fatal as booleans
Jens Axboe [Fri, 10 Aug 2007 08:32:14 +0000 (10:32 +0200)]
Mark do_verify and verify_fatal as booleans

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoAdd verify_fatal option
Jens Axboe [Thu, 9 Aug 2007 08:20:54 +0000 (10:20 +0200)]
Add verify_fatal option

Causes fio to exit after a single block verification failure, instead of
checking the remainder as well.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoImprove verify pattern failure logging
Jens Axboe [Thu, 9 Aug 2007 08:16:31 +0000 (10:16 +0200)]
Improve verify pattern failure logging

Show number of bad bits and block offset.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoNote parent option 'verify' for 'do_verify'
Jens Axboe [Thu, 2 Aug 2007 20:21:36 +0000 (22:21 +0200)]
Note parent option 'verify' for 'do_verify'

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years ago[PATCH] Add do_verify option
Shawn Lewis [Thu, 2 Aug 2007 20:19:32 +0000 (22:19 +0200)]
[PATCH] Add do_verify option

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoVerify the pattern we've written
Shawn Lewis [Thu, 2 Aug 2007 20:18:29 +0000 (22:18 +0200)]
Verify the pattern we've written

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years ago[PATCH] Fix memswp. Its scratch space was too small
Shawn Lewis [Thu, 2 Aug 2007 20:17:52 +0000 (22:17 +0200)]
[PATCH] Fix memswp. Its scratch space was too small

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years ago[PATCH] Add verify_meta verification type
Shawn Lewis [Thu, 2 Aug 2007 19:05:58 +0000 (21:05 +0200)]
[PATCH] Add verify_meta verification type

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoMore option help updates
Jens Axboe [Tue, 31 Jul 2007 21:12:16 +0000 (23:12 +0200)]
More option help updates

Rearrange some of the entries, and add more parent <-> child links.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoBe a little more clever in finding child options
Jens Axboe [Tue, 31 Jul 2007 21:06:09 +0000 (23:06 +0200)]
Be a little more clever in finding child options

We don't need ->parent_seen, just start from the next option.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoParent options didn't recurse properly
Jens Axboe [Tue, 31 Jul 2007 20:56:53 +0000 (22:56 +0200)]
Parent options didn't recurse properly

It only displayed the first found. Add a ->parent_seen and
find all matches.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoAdd parent option to 'verifysort'
Jens Axboe [Tue, 31 Jul 2007 20:51:47 +0000 (22:51 +0200)]
Add parent option to 'verifysort'

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoAdd parent link to options
Jens Axboe [Tue, 31 Jul 2007 14:14:34 +0000 (16:14 +0200)]
Add parent link to options

Then we can nest display for --cmdhelp=all, to tie options
together.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoUpdate non-linux Makefiles
Jens Axboe [Mon, 30 Jul 2007 10:29:37 +0000 (12:29 +0200)]
Update non-linux Makefiles

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoMove checksumming files to seperate directory
Jens Axboe [Mon, 30 Jul 2007 10:27:58 +0000 (12:27 +0200)]
Move checksumming files to seperate directory

Too many of them now, move them out-of-sight. They will rarely
be modified anyway.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoSeperate verify_header from the checksum type
Jens Axboe [Mon, 30 Jul 2007 10:23:05 +0000 (12:23 +0200)]
Seperate verify_header from the checksum type

If using one of the leaner checksums, we potentially have almost
128 more bytes of real data in a block.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoPrepare for splitting the verify_header from the checksum header
Jens Axboe [Mon, 30 Jul 2007 10:08:14 +0000 (12:08 +0200)]
Prepare for splitting the verify_header from the checksum header

Some of the checksums carry a lot of data. We unionize the checksum
header right now inside the verify header, causing a lot of wasted
space for the leaner variants.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoAdd sha256 and sha512 checksums
Jens Axboe [Mon, 30 Jul 2007 08:59:33 +0000 (10:59 +0200)]
Add sha256 and sha512 checksums

That should suffice...

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoProperly initialize md5 hash seed
Jens Axboe [Mon, 30 Jul 2007 08:18:06 +0000 (10:18 +0200)]
Properly initialize md5 hash seed

We started from 0, that's not entirely correct.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoRemove .maxval from verify_pattern
Jens Axboe [Mon, 30 Jul 2007 07:50:13 +0000 (09:50 +0200)]
Remove .maxval from verify_pattern

Let the parser handle it.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoAdd verify_pattern option
Jens Axboe [Mon, 30 Jul 2007 07:33:12 +0000 (09:33 +0200)]
Add verify_pattern option

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoDocument parser int taking hex input
Jens Axboe [Mon, 30 Jul 2007 07:08:01 +0000 (09:08 +0200)]
Document parser int taking hex input

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoParser: make check_int() accept hex input if prefixed with 0x
Jens Axboe [Mon, 30 Jul 2007 07:07:04 +0000 (09:07 +0200)]
Parser: make check_int() accept hex input if prefixed with 0x

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoRename header_offset and header_interval options
Jens Axboe [Mon, 30 Jul 2007 06:53:27 +0000 (08:53 +0200)]
Rename header_offset and header_interval options

Header doesn't really express that this has to do with io verification.
So rename the options to verify_offset and verify_interval.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoFix bug in md5 calculation
Jens Axboe [Sun, 29 Jul 2007 18:59:01 +0000 (20:59 +0200)]
Fix bug in md5 calculation

Commit 8c432325c3df2075a77b27eab8a87704cf7b48ee introduced a bug for
smaller sizes. Just basically revert the optimization, safer to stay
with a 'reference' implementation than skip a memset.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoFix md5 verify
Jens Axboe [Sun, 29 Jul 2007 06:49:16 +0000 (08:49 +0200)]
Fix md5 verify

The header_interval/offset changes introduced a bug, doing sizeof
on a pointer where it should have been the array. So we didn't compare
the full md5, just the first sizeof(pointer) bytes.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoFix header_interval minimum value
Jens Axboe [Sat, 28 Jul 2007 19:30:31 +0000 (21:30 +0200)]
Fix header_interval minimum value

It doesn't make sense to have a value of header size or less, since
then there's no room for actual data. Fio even crashes with a value
less than the header size.

Lets just make the minimum twice the header size, seems reasonable...

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoAbstract out the data offset calculation
Jens Axboe [Sat, 28 Jul 2007 19:22:03 +0000 (21:22 +0200)]
Abstract out the data offset calculation

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoCleanup verify pointer casting
Jens Axboe [Sat, 28 Jul 2007 19:17:50 +0000 (21:17 +0200)]
Cleanup verify pointer casting

Just make 'p' void *, like io_u->buf.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years ago[PATCH] Offset verification header by a user-specified distance
Shawn Lewis [Sat, 28 Jul 2007 19:11:37 +0000 (21:11 +0200)]
[PATCH] Offset verification header by a user-specified distance

Offset verification header by user specified distance.

 - Implementation is somewhat simple and probably not ideal but it works. The
   header is just swapped with the bytes at offset after the chunk has been
   filled during populate. Everything is swapped back before verify.

 - Also fixes a bug where we were relying on a moving pointer for increment
   size in populate_verify_io_u (which was working until this patch).

 - Also cleans up a couple smalls things from the header_interval patch.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years ago[PATCH] Allow verification to be done at finer granularity
Shawn Lewis [Sat, 28 Jul 2007 19:10:37 +0000 (21:10 +0200)]
[PATCH] Allow verification to be done at finer granularity

Allow verification to be done at a finer granularity than blocksize.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years ago[PATCH] Fix file_size_high
ljzhang,Yaxin Hu,Jianchao Tang [Fri, 27 Jul 2007 13:54:10 +0000 (15:54 +0200)]
[PATCH] Fix file_size_high

It is generating a size between

[file_size_low, file_size_low+file_size_high]

where it should be

[file_size_low, file_size_high].

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoShow md5 as first verify function
Jens Axboe [Fri, 27 Jul 2007 13:42:00 +0000 (15:42 +0200)]
Show md5 as first verify function

It's probably the best/fastest choice.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoAdd crc7 and crc64 to HOWTO
Jens Axboe [Fri, 27 Jul 2007 13:36:02 +0000 (15:36 +0200)]
Add crc7 and crc64 to HOWTO

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years agoAdd sample crc64 checksum
Jens Axboe [Fri, 27 Jul 2007 13:35:06 +0000 (15:35 +0200)]
Add sample crc64 checksum

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
12 years ago[PATCH] Fix fileoffset option
ljzhang,Yaxin Hu,Jianchao Tang [Fri, 27 Jul 2007 11:28:26 +0000 (13:28 +0200)]
[PATCH] Fix fileoffset option

1. The job file we prepared:
----------offset-----------------
[global]
filename=./temp/HOWTO
nrfiles=1
rw=read
size=8K
offset=16k
bs=1k
thread
loops=10
[offset]
description="Option 'offset' doesn't work."
---------------------------------
Besides, we copied the file HOWTO to the directory ./temp/.
So we thought fio would read 8K text sequentially from the point 16K off
the beginning of HOWTO.

we run fio with gdb to see what was read out after the first io, and we
got this:
---------------------------------
... ...
(gdb) bt
from /lib/tls/i686/cmov/libpthread.so.0
(gdb) x/4w io_u->xfer_buf
0x8073f08:      0x6c626154      0x666f2065      0x6e6f6320
0x746e6574
(gdb)
---------------------------------
The above was performed after the first io finished by td_io_queue.
The contents read out as we can see was the ASCII codes for 'Table of
content', which was right from the beginning of file HOWTO.
That means fio read from the beginning but not the point 16K off the
beginning.Is that right?

2. Reason for the problem:
It seems the offset is saved in td->o.start_offset. But it isn't passed
to  f->file_offset.And the setting up of f->io_size doesn't refer to
f->file_offset.

--------------------------------------------------------

And now we can check it with gdb:
--------------------------------------------------------
... ...
(gdb) bt
from /lib/tls/i686/cmov/libpthread.so.0
(gdb) x/4w io_u->xfer_buf
0x8073f08:      0x206b636f      0x7420666f      0x66206568
0x20656c69
(gdb)
---------------------------------------------------------
After the first io, I got '0x206b636f 0x7420666f 0x66206568 0x20656c69'
read out.And they represent the string 'ock of the file '.Then i search
the string in HOWTO and got only one line containing the string:
'norandommap Normally fio will cover every block of the file when doing'
I removed the text following that line in HOWTO, and then I found that
the size of the rest text in HOWTO was 16K, which equaled to the offset
we set in job file.
So I think the option 'offset' does work after the changes.

In fact, I am not sure of the fix, but i do hope it can help.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>