From: Jens Axboe <axboe@kernel.dk>
Date: Fri, 29 Dec 2017 15:45:22 +0000 (-0700)
Subject: log: fix bad < 0 check for unsigned
X-Git-Tag: fio-3.4~31
X-Git-Url: https://git.kernel.dk/?p=fio.git;a=commitdiff_plain;h=df4bf1178ed773986129da6038961388af926971

log: fix bad < 0 check for unsigned

Fixes: e5f9a813 ("debug: make debug=io readable with multiple threads")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/log.c b/log.c
index 291ff24a..a327f6aa 100644
--- a/log.c
+++ b/log.c
@@ -98,7 +98,7 @@ void log_prevalist(int type, const char *fmt, va_list args)
 	char pre[32];
 	char *buffer;
 	size_t len;
-	size_t prelen;
+	int prelen;
 	pid_t pid;
 
 	pid = gettid();
@@ -107,14 +107,11 @@ void log_prevalist(int type, const char *fmt, va_list args)
 		return;
 
 	prelen = snprintf(pre, sizeof pre, "%-8s %-5u ", debug_levels[type].name, (int) pid);
-	if (prelen < 0)
-		return;
-
-	len = prevalist_to_buf(&buffer, pre, prelen, fmt, args);
-	len = log_info_buf(buffer, len);
-	free(buffer);
-
-	return;
+	if (prelen > 0) {
+		len = prevalist_to_buf(&buffer, pre, prelen, fmt, args);
+		len = log_info_buf(buffer, len);
+		free(buffer);
+	}
 }
 
 size_t log_info(const char *format, ...)