From: Jens Axboe <axboe@fb.com>
Date: Fri, 22 Aug 2014 15:22:03 +0000 (-0500)
Subject: options: warn if we fail to make sense of buffer_pattern
X-Git-Tag: fio-2.1.12~5
X-Git-Url: https://git.kernel.dk/?p=fio.git;a=commitdiff_plain;h=d2ba0d7c5b9b3ddd78e917a2c9e2ca98608f9480;ds=sidebyside

options: warn if we fail to make sense of buffer_pattern

Signed-off-by: Jens Axboe <axboe@fb.com>
---

diff --git a/options.c b/options.c
index 3acfdc86..5f4a8ec2 100644
--- a/options.c
+++ b/options.c
@@ -985,8 +985,8 @@ static int pattern_cb(char *pattern, unsigned int max_size,
 
 	if (i == 1) {
 		/*
-		 * The code in verify_io_u_pattern assumes a single byte pattern
-		 * fills the whole verify pattern buffer.
+		 * The code in verify_io_u_pattern assumes a single byte
+		 * pattern fills the whole verify pattern buffer.
 		 */
 		memset(pattern, pattern[0], max_size);
 	}
@@ -1003,10 +1003,13 @@ static int str_buffer_pattern_cb(void *data, const char *input)
 	ret = pattern_cb(td->o.buffer_pattern, MAX_PATTERN_SIZE, input,
 				&td->o.buffer_pattern_bytes);
 
-	if (!ret) {
+	if (!ret && td->o.buffer_pattern_bytes) {
 		td->o.refill_buffers = 0;
 		td->o.scramble_buffers = 0;
 		td->o.zero_buffers = 0;
+	} else {
+		log_err("fio: failed parsing pattern `%s`\n", input);
+		ret = 1;
 	}
 
 	return ret;