From: Stefan Hajnoczi <stefanha@redhat.com>
Date: Thu, 6 May 2021 16:23:31 +0000 (+0100)
Subject: configure: fix check_min_lib_version() eval
X-Git-Tag: fio-3.27~13
X-Git-Url: https://git.kernel.dk/?p=fio.git;a=commitdiff_plain;h=cffe80a41cbf9b26446c803177a27f7695f94a31;ds=inline

configure: fix check_min_lib_version() eval

The following shell statement:

  if eval "echo \$$_feature" = "yes" ; then

executes:

  echo $... = "yes"

It does not actually compare the variable named by $_feature to the
string "yes".

Add the missing "test" call so the comparison happens as intended and
wrap the eval so it doesn't include the = "yes".

Fixes: 3e48f7c9de61 ("configure: fix syntax error with NetBSD")
Cc: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/configure b/configure
index a7d82be0..e886bdc8 100755
--- a/configure
+++ b/configure
@@ -142,7 +142,7 @@ check_min_lib_version() {
   fi
   : "${_feature:=${1}}"
   if "${cross_prefix}"pkg-config --version > /dev/null 2>&1; then
-    if eval "echo \$$_feature" = "yes" ; then
+    if test "$(eval echo \"\$$_feature\")" = "yes" ; then
       feature_not_found "$_feature" "$1 >= $2"
     fi
   else