From: Adam DeBellins Date: Tue, 28 Sep 2010 04:22:55 +0000 (+0900) Subject: Fix bad setting of td->o.ddir_seq_nr in add_job() X-Git-Tag: fio-1.44~2 X-Git-Url: https://git.kernel.dk/?p=fio.git;a=commitdiff_plain;h=cdd5411e02b05f5c9fd305a0f07f58e3abef4d5e Fix bad setting of td->o.ddir_seq_nr in add_job() This defaults to 1, but add_job() adds 1 again which means that the random isn't always effective since every alternate IO gets to bypass that logic. Signed-off-by: Jens Axboe --- diff --git a/init.c b/init.c index cc4037a7..b84d0ad4 100644 --- a/init.c +++ b/init.c @@ -561,7 +561,7 @@ static int add_job(struct thread_data *td, const char *jobname, int job_add_num) td->ts.slat_stat[0].min_val = td->ts.slat_stat[1].min_val = ULONG_MAX; td->ts.lat_stat[0].min_val = td->ts.lat_stat[1].min_val = ULONG_MAX; td->ts.bw_stat[0].min_val = td->ts.bw_stat[1].min_val = ULONG_MAX; - td->ddir_seq_nr = td->o.ddir_seq_nr + 1; + td->ddir_seq_nr = td->o.ddir_seq_nr; if ((td->o.stonewall || td->o.new_group) && prev_group_jobs) { prev_group_jobs = 0;