From: Sitsofe Wheeler <sitsofe@yahoo.com>
Date: Thu, 9 Feb 2017 06:30:04 +0000 (+0000)
Subject: verify: warn when verify pass won't be run
X-Git-Tag: fio-3.1~29^2
X-Git-Url: https://git.kernel.dk/?p=fio.git;a=commitdiff_plain;h=b9f3ee6cfd6242f058643ccf8266fd75a9625482;hp=9f6d708041c703b6a4168176653faf1869a22d46

verify: warn when verify pass won't be run

Put up a warning when the user sets write + verify + runtime +
time_based together because the runtime is completely used by the write
phase but skip the warning if the user is doing verifies "inline" within
the write phase via verify_backlog or they are doing a mixed read/write
workload where the reads might be verifying.

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
---

diff --git a/init.c b/init.c
index 5054c54b..7fbfa866 100644
--- a/init.c
+++ b/init.c
@@ -743,6 +743,18 @@ static int fixup_options(struct thread_data *td)
 			ret = warnings_fatal;
 		}
 
+		/*
+		 * Warn if verification is requested but no verification of any
+		 * kind can be started due to time constraints
+		 */
+		if (td_write(td) && o->do_verify && o->timeout &&
+		    o->time_based && !td_read(td) && !o->verify_backlog) {
+			log_info("fio: verification read phase will never "
+				 "start because write phase uses all of "
+				 "runtime\n");
+			ret = warnings_fatal;
+		}
+
 		if (!fio_option_is_set(o, refill_buffers))
 			o->refill_buffers = 1;