From: Tomohiro Kusumi <tkusumi@tuxera.com>
Date: Mon, 12 Jun 2017 20:02:06 +0000 (+0300)
Subject: sg: add missing free(msg); in ->errdetails() handler
X-Git-Tag: fio-2.21~7
X-Git-Url: https://git.kernel.dk/?p=fio.git;a=commitdiff_plain;h=b63fe8bec4c7f5defe6b6842b4d251ecc67add60

sg: add missing free(msg); in ->errdetails() handler

msg gets malloc'd unconditionally, so we need to free msg if we're
not using msg for ret (strdup isn't really needed here to begin with).

Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
---

diff --git a/engines/sg.c b/engines/sg.c
index 2148e87c..9d339bd3 100644
--- a/engines/sg.c
+++ b/engines/sg.c
@@ -759,8 +759,10 @@ static char *fio_sgio_errdetails(struct io_u *io_u)
 		}
 	}
 
-	if (!ret)
+	if (!ret) {
 		ret = strdup("SG Driver did not report a Host, Driver or Device check");
+		free(msg);
+	}
 
 	return ret;
 }