From: Stephen M. Cameron <stephenmcameron@gmail.com>
Date: Tue, 30 Sep 2014 14:31:04 +0000 (-0500)
Subject: do not call fprintf from yyerror in expression parser
X-Git-Tag: fio-2.1.14~101^2~5
X-Git-Url: https://git.kernel.dk/?p=fio.git;a=commitdiff_plain;h=7ff01fbe0cf65b0a31bda0874b12b9407fea24f9

do not call fprintf from yyerror in expression parser

Signed-off-by: Stephen M. Cameron <stephenmcameron@gmail.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
---

diff --git a/exp/expression-parser.y b/exp/expression-parser.y
index 6ab64088..87ead8ac 100644
--- a/exp/expression-parser.y
+++ b/exp/expression-parser.y
@@ -229,9 +229,10 @@ int evaluate_arithmetic_expression(const char *buffer, long long *ival, double *
 int yyerror(__attribute__((unused)) long long *result,
 		__attribute__((unused)) double *dresult,
 		__attribute__((unused)) int *has_error,
-		__attribute__((unused)) int *bye, const char *msg)
+		__attribute__((unused)) int *bye,
+		__attribute__((unused)) const char *msg)
 {
-	fprintf(stderr, "%s\n", msg);
+	/* We do not need to do anything here. */
 	return 0;
 }
 
diff --git a/exp/test-expression-parser.c b/exp/test-expression-parser.c
index 022df011..45151442 100644
--- a/exp/test-expression-parser.c
+++ b/exp/test-expression-parser.c
@@ -44,6 +44,7 @@ int main(int argc, char *argv[])
 		if (!rc) {
 			printf("%lld (%20.20lf)\n", result, dresult);
 		} else {
+			fprintf(stderr, "Syntax error\n");
 			result = 0;
 			dresult = 0;
 		}