From: Jens Axboe <jaxboe@fusionio.com>
Date: Thu, 12 May 2011 08:14:57 +0000 (+0200)
Subject: Fix crash on specifying bad IO engine on the command line
X-Git-Tag: fio-1.54~1
X-Git-Url: https://git.kernel.dk/?p=fio.git;a=commitdiff_plain;h=6625155407de739e1e857419b7b4fb62f6c6bb2e

Fix crash on specifying bad IO engine on the command line

Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
---

diff --git a/init.c b/init.c
index 37e0c481..26e42ef6 100644
--- a/init.c
+++ b/init.c
@@ -568,7 +568,7 @@ static int add_job(struct thread_data *td, const char *jobname, int job_add_num)
 	}
 
 	if (profile_td_init(td))
-		return 1;
+		goto err;
 
 	engine = get_engine_name(td->o.ioengine);
 	td->io_ops = load_ioengine(td, engine);
@@ -1222,10 +1222,8 @@ static int parse_cmd_line(int argc, char *argv[])
 
 			if (!strncmp(opt, "name", 4) && td) {
 				ret = add_job(td, td->o.name ?: "fio", 0);
-				if (ret) {
-					put_job(td);
+				if (ret)
 					return 0;
-				}
 				td = NULL;
 			}
 			if (!td) {
@@ -1262,8 +1260,6 @@ static int parse_cmd_line(int argc, char *argv[])
 	if (td) {
 		if (!ret)
 			ret = add_job(td, td->o.name ?: "fio", 0);
-		if (ret)
-			put_job(td);
 	}
 
 	while (optind < argc) {