From: Jens Axboe <jens.axboe@oracle.com>
Date: Fri, 19 Mar 2010 07:08:06 +0000 (+0100)
Subject: Don't call getpid() in dprint() unless we are going to use it
X-Git-Tag: fio-1.38~10
X-Git-Url: https://git.kernel.dk/?p=fio.git;a=commitdiff_plain;h=440a5981b37580b3c0f5109bc7f6b5a412ab67fc

Don't call getpid() in dprint() unless we are going to use it

Reported-by: David Andersen <dga@cs.cmu.edu>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
---

diff --git a/debug.h b/debug.h
index 71b346d8..891c254e 100644
--- a/debug.h
+++ b/debug.h
@@ -34,15 +34,16 @@ extern unsigned long fio_debug;
 
 #define dprint(type, str, args...)				\
 	do {							\
-		pid_t pid = getpid();				\
+		pid_t __pid;					\
 		assert(type < FD_DEBUG_MAX);			\
 		if ((((1 << type)) & fio_debug) == 0)		\
 			break;					\
+		__pid = getpid();				\
 		if (fio_debug_jobp && *fio_debug_jobp != -1U	\
-		    && pid != *fio_debug_jobp)			\
+		    && __pid != *fio_debug_jobp)		\
 			break;					\
 		log_info("%-8s ", debug_levels[(type)].name);	\
-		log_info("%-5u ", (int) pid);			\
+		log_info("%-5u ", (int) __pid);			\
 		log_info(str, ##args);				\
 	} while (0)