From: Jens Axboe <axboe@fb.com>
Date: Wed, 20 Jan 2016 19:17:54 +0000 (-0700)
Subject: client: fix non-text command leak
X-Git-Tag: fio-2.4~2
X-Git-Url: https://git.kernel.dk/?p=fio.git;a=commitdiff_plain;h=2baadb02756d2abaf7ba0fd8bb1cfb6b83f887c1

client: fix non-text command leak

Signed-off-by: Jens Axboe <axboe@fb.com>
---

diff --git a/client.c b/client.c
index c61301de..2541f462 100644
--- a/client.c
+++ b/client.c
@@ -226,13 +226,12 @@ static void fio_drain_client_text(struct fio_client *client)
 		if (!cmd)
 			break;
 
-		if (cmd->opcode != FIO_NET_CMD_TEXT) {
-			free(cmd);
-			continue;
+		if (cmd->opcode == FIO_NET_CMD_TEXT) {
+			convert_text(cmd);
+			client->ops->text(client, cmd);
 		}
 
-		convert_text(cmd);
-		client->ops->text(client, cmd);
+		free(cmd);
 	} while (1);
 }