From: Jens Axboe <axboe@kernel.dk>
Date: Sat, 2 Feb 2013 08:56:23 +0000 (+0100)
Subject: parse: use MIN/MAXDOUBLE instead of some representation of NAN
X-Git-Tag: fio-2.0.14~46
X-Git-Url: https://git.kernel.dk/?p=fio.git;a=commitdiff_plain;h=266506958a1dbaa41800f0b1170217d81c702f47;ds=sidebyside

parse: use MIN/MAXDOUBLE instead of some representation of NAN

Doesn't always work for C99.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/parse.c b/parse.c
index 3fda69cd..144794aa 100644
--- a/parse.c
+++ b/parse.c
@@ -10,6 +10,7 @@
 #include <limits.h>
 #include <stdlib.h>
 #include <math.h>
+#include <values.h>
 
 #include "parse.h"
 #include "debug.h"
@@ -50,11 +51,11 @@ static void show_option_range(struct fio_option *o,
 				int (*logger)(const char *format, ...))
 {
 	if (o->type == FIO_OPT_FLOAT_LIST){
-		if (isnan(o->minfp) && isnan(o->maxfp))
+		if (o->minfp == MINDOUBLE && o->maxfp == MAXDOUBLE)
 			return;
 
 		logger("%20s: min=%f", "range", o->minfp);
-		if (!isnan(o->maxfp))
+		if (o->maxfp != MAXDOUBLE)
 			logger(", max=%f", o->maxfp);
 		logger("\n");
 	} else {
@@ -510,12 +511,12 @@ static int __handle_option(struct fio_option *o, const char *ptr, void *data,
 			log_err("not a floating point value: %s\n", ptr);
 			return 1;
 		}
-		if (!isnan(o->maxfp) && uf > o->maxfp) {
+		if (uf > o->maxfp) {
 			log_err("value out of range: %f"
 				" (range max: %f)\n", uf, o->maxfp);
 			return 1;
 		}
-		if (!isnan(o->minfp) && uf < o->minfp) {
+		if (uf < o->minfp) {
 			log_err("value out of range: %f"
 				" (range min: %f)\n", uf, o->minfp);
 			return 1;
@@ -1091,11 +1092,8 @@ void option_init(struct fio_option *o)
 			o->maxval = UINT_MAX;
 	}
 	if (o->type == FIO_OPT_FLOAT_LIST) {
-#ifndef NAN
-#define NAN __builtin_nanf("")
-#endif
-		o->minfp = NAN;
-		o->maxfp = NAN;
+		o->minfp = MINDOUBLE;
+		o->maxfp = MAXDOUBLE;
 	}
 	if (o->type == FIO_OPT_STR_SET && o->def) {
 		log_err("Option %s: string set option with"