From: Jens Axboe <axboe@fb.com>
Date: Fri, 11 Apr 2014 17:27:34 +0000 (-0600)
Subject: Fix leak of file descriptor in error path of bc_calc()
X-Git-Tag: fio-2.1.9~75
X-Git-Url: https://git.kernel.dk/?p=fio.git;a=commitdiff_plain;h=1d824f370d9e7fb9fc5aa23bc847c31c8467367a;ds=inline

Fix leak of file descriptor in error path of bc_calc()

Signed-off-by: Jens Axboe <axboe@fb.com>
---

diff --git a/options.c b/options.c
index 5c372b69..9096a322 100644
--- a/options.c
+++ b/options.c
@@ -3656,8 +3656,10 @@ static char *bc_calc(char *str)
 		return NULL;
 
 	ret = fread(&buf[tmp - str], 1, 128 - (tmp - str), f);
-	if (ret <= 0)
+	if (ret <= 0) {
+		pclose(f);
 		return NULL;
+	}
 
 	pclose(f);
 	buf[(tmp - str) + ret - 1] = '\0';