From: Jens Axboe <axboe@fb.com>
Date: Tue, 8 Jul 2014 07:45:55 +0000 (+0200)
Subject: tp: move pthread_cond_signal() outside of lock
X-Git-Tag: fio-2.1.11~12
X-Git-Url: https://git.kernel.dk/?p=fio.git;a=commitdiff_plain;h=1b06fdb4fa31b6aa6e7baec5c73926870480623f

tp: move pthread_cond_signal() outside of lock

Signed-off-by: Jens Axboe <axboe@fb.com>
---

diff --git a/lib/tp.c b/lib/tp.c
index ec52db6d..386e31af 100644
--- a/lib/tp.c
+++ b/lib/tp.c
@@ -63,8 +63,9 @@ void tp_queue_work(struct tp_data *tdat, struct tp_work *work)
 
 	pthread_mutex_lock(&tdat->lock);
 	flist_add_tail(&work->list, &tdat->work);
-	pthread_cond_signal(&tdat->cv);
 	pthread_mutex_unlock(&tdat->lock);
+
+	pthread_cond_signal(&tdat->cv);
 }
 
 void tp_init(struct tp_data **tdatp)
@@ -94,11 +95,12 @@ void tp_exit(struct tp_data **tdatp)
 	if (!tdat)
 		return;
 
-	tdat->thread_exit = 1;
 	pthread_mutex_lock(&tdat->lock);
-	pthread_cond_signal(&tdat->cv);
+	tdat->thread_exit = 1;
 	pthread_mutex_unlock(&tdat->lock);
 
+	pthread_cond_signal(&tdat->cv);
+
 	pthread_join(tdat->thread, &ret);
 
 	sfree(tdat);