From: Jens Axboe <axboe@kernel.dk>
Date: Wed, 9 Nov 2011 19:25:21 +0000 (+0100)
Subject: Fix crash when attempting to dupe options
X-Git-Tag: fio-1.99.12~1
X-Git-Url: https://git.kernel.dk/?p=fio.git;a=commitdiff_plain;h=1647f592cc93364e018ed149cb1a5b6a7dc598b9;ds=sidebyside

Fix crash when attempting to dupe options

If the engine has extended options but isn't loaded, boom.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/options.c b/options.c
index 6352f0a8..53c3a826 100644
--- a/options.c
+++ b/options.c
@@ -2484,8 +2484,10 @@ void options_mem_dupe(void *data, struct fio_option *options)
 void fio_options_mem_dupe(struct thread_data *td)
 {
 	options_mem_dupe(&td->o, options);
-	if (td->eo) {
+
+	if (td->eo && td->io_ops) {
 		void *oldeo = td->eo;
+
 		td->eo = malloc(td->io_ops->option_struct_size);
 		memcpy(td->eo, oldeo, td->io_ops->option_struct_size);
 		options_mem_dupe(td->eo, td->io_ops->options);