From: Bart Van Assche <bart.vanassche@wdc.com>
Date: Tue, 5 Jun 2018 17:15:18 +0000 (+0200)
Subject: Make nowarn_snprintf() call va_end()
X-Git-Tag: fio-3.8~49^2
X-Git-Url: https://git.kernel.dk/?p=fio.git;a=commitdiff_plain;h=0b4a7080c22fb0f2e5be72ac6ec9a61a1e44b336

Make nowarn_snprintf() call va_end()

This patch suppresses the following Coverity complaint:

CID 175867:  API usage errors  (VARARGS)
    va_end was not called for "args".

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
---

diff --git a/lib/nowarn_snprintf.h b/lib/nowarn_snprintf.h
index 5c0f4d44..81a6d108 100644
--- a/lib/nowarn_snprintf.h
+++ b/lib/nowarn_snprintf.h
@@ -8,17 +8,20 @@ static inline int nowarn_snprintf(char *str, size_t size, const char *format,
 				  ...)
 {
 	va_list args;
+	int res;
 
 	va_start(args, format);
 #if __GNUC__ -0 >= 8
 #pragma GCC diagnostic push "-Wformat-truncation"
 #pragma GCC diagnostic ignored "-Wformat-truncation"
 #endif
-	return vsnprintf(str, size, format, args);
+	res = vsnprintf(str, size, format, args);
 #if __GNUC__ -0 >= 8
 #pragma GCC diagnostic pop "-Wformat-truncation"
 #endif
 	va_end(args);
+
+	return res;
 }
 
 #endif